• Resolved amishdirect

    (@amishdirect)


    Hi there!

    First off, awesome plugin. I’ve noticed on the latest update when you click “Add a saved tab” the WYSIWYG form is broken and the saved form doesn’t load right. If you click it again it finally loads in as a second tab and when you go to delete the first one, it deletes the second one instead. If you click and add it a third time with both gone it final loads it in properly but the WYSIWYG form is still broken. Every saves just fine but I wonder if it has to due with the latest WordPress update. Please let me know if this is just on our end or not.

    Thanks!

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Contributor yikesitskevin

    (@yikesitskevin)

    Hello @amishdirect,

    You are using the latest version of WordPress, correct?

    The latest version of WordPress (v4.8) came with some new WYSIWYG features. I used these new features in the latest version of the Custom Product tabs plugin, whilst trying to maintain backwards compatibility. I will test the plugin again this morning on both v4.8 and v<4.8 but please let me know which version you are using.

    Thank you for reporting this and sorry for the issue!

    Cheers,
    Kevin.

    Plugin Contributor yikesitskevin

    (@yikesitskevin)

    Hello @amishdirect,

    I’ve done some testing an am unable to replicate this issue. Any additional information you have as to specific steps you’re taking would be appreciated. Is this a brand new product, or a product with existing tabs? Are you using the latest version of WooCommerce, Custom Product Tabs, and WordPress? Does adding a normal custom tab work okay?

    As I said, any information will help!

    Kevin.

    Thread Starter amishdirect

    (@amishdirect)

    I am on the latest version of both the plugin and WordPress. I’ve created a screen recording on our dev site and it happens there as well. Here is the link so you can actually see what I’m talking about:

    https://www.dropbox.com/s/x9jdyhuyrmfocc5/tabissue.mov?dl=0

    If the link doesn’t work let me know.

    Hope this helps!

    Thread Starter amishdirect

    (@amishdirect)

    Checking in. Were you able to watch the video of the issue? If so were you able to replicate it or find a fix? Let me know, thanks!

    Thread Starter amishdirect

    (@amishdirect)

    Well I jerry-rigged it for the time being by re-adding the wpembed plugin to wp-includes and downgraded the plugin to 1.5.14 and everything works like it did before. Obviously if we update WordPress I’ll have to readd the wpembed every time which isn’t something I want to do. Let me know if you guys come up with a fix but in the meantime I got everything to work.

    Plugin Contributor yikesitskevin

    (@yikesitskevin)

    Hello @amishdirect,

    My apologies for the delay; I am on a business trip/vacation at the moment and have not been able to answer all of my emails. I am still unable to replicate this, but I’ve watched the Dropbox video and see the issue.

    I noticed that you have few additional panels in your WooCommerce table (i.e. Extras, Restrictions, and TM Extra Product Options). I am wondering if somehow these are conflicting. Are these publicly available plugins? Can I download them and test this?

    Again, sorry for the delay.

    Kevin.

    Thread Starter amishdirect

    (@amishdirect)

    Hi Kevin!

    I believe I found our issue. It’s due to our theme. It has some custom formatting being added to the TinyMCE and I didn’t realize that was updated in 4.8 which is why this plugin is being broken.

    Plugin Contributor yikesitskevin

    (@yikesitskevin)

    Hi @amishdirect,

    Ahh! That makes a lot of sense! 4.8 is throwing a lot of us for a spin.

    What was the fix? Did you remove the custom features from the theme or did the theme have an update?

    Regardless, glad it’s working and I apologize for the previous response delay.

    Kevin.

    Thread Starter amishdirect

    (@amishdirect)

    There isn’t a fix yet but the author of the theme is aware of the issue that their hooks into the TinyMCE are causing with the latest 4.8 update. I swapped over to the 2017 WP theme to see if it was a theme issue because I noticed the TinyMCE was different on our current theme compared to what it looked like with the 2017 theme on. I tried to add a saved tab and it worked just fine, well, the form comes in starting at half size and you have to resize it but that’s about it. So until they come out with a fix I have that janky fix still on our site.

    And no problem on the delay. Stuff happens and I’d figured I’d let you know that our issue has nothing to do with the plugin.

    Plugin Contributor yikesitskevin

    (@yikesitskevin)

    Sounds good, thanks for the update.

    I’m not sure what to do about the oddly-sized editor; I know exactly what you’re talking about though. Themes have the ability to define their own editor styles so I’m usually wary of trying to stylize the editor. I’m also thinking that this issue isn’t isolated to my plugin and maybe a Core fix will come out. If nothing changes in the next week or so I’ll be pushing a fix for that.

    Thanks for your understanding!

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Form breaking on latest update’ is closed to new replies.