file urls no longer work properly on 7.7 (absolute paths appended)

If you use the cron version you will also need to replace the same like in the MediaFromFtpCron.php

Hi juz501,

What about this code?

if ( !strpos($searchdir, '../') ) {
$document_root = ABSPATH.$searchdir;
} else {
$document_root = realpath(ABSPATH.$searchdir);
}

I’m sorry.
It had been a mistake.

False strpos
True strstr

The issue is that the absolute path (created by realpath) is appended to the original host

https://examplewordpress/var/www/testwordpress/wp-content/uploads/2015/07

when it should really just be

https://examplewordpress.com/wp-content/uploads/2015/07

I’m unsure what the realpath is meant to achieve by setting it as the document root.. you should either use the absolute path or the absolute url. not combine them together.

to be honest.. all u need to do is use the basename function before you add it to the file list $list

Hi juz501,

$document_root is, it must be an absolute path we will use to search for files.
when make URLs and copy files,
These Constant

MEDIAFROMFTP_PLUGIN_UPLOAD_DIR
MEDIAFROMFTP_PLUGIN_UPLOAD_URL
MEDIAFROMFTP_PLUGIN_UPLOAD_PATH

Add processing.

By environment, it might last a slash(/) of these constants from being added. At that time, I think or not than is this error will come out.
How it will be in your environment?

You can see it and add the following code to the 400 per line of MediaFromFtpAdmin.php.
You can look at “search & register”.

echo MEDIAFROMFTP_PLUGIN_UPLOAD_URL.'::'.MEDIAFROMFTP_PLUGIN_UPLOAD_DIR.'::'.MEDIAFROMFTP_PLUGIN_UPLOAD_PATH;

unfortunately we are the process of deploying live so we can’t test this for you.. I’ll get back to you when I have more time to look into the reason…..

But I am pretty certain the actual bug is in the input_url function in MediaFromFtp.php around line 296 and the actual culprit line is line 307 which says:

$new_url = site_url('/').str_replace(ABSPATH, '', $file);

but it really shouldn’t be appending ABSPATH with site_url.

I have a feeling 7.8 fixed the issue, i checked the diff looked pretty good.
However it doesn’t fix up any damage done by using 7.7

Their meanings are as follows.

$new_url = site_url('/').str_replace(ABSPATH, '', $ file);

Example

$file  /usr/local/wordpress/wp-content/uploads/test.jpg
ABSPATH  /usr/local/wordpress/
site_url('/')  https://test.com/wordpress/

$new_url  https://test.com/wordpress/wp-content/uploads/test.jpg

Remove the ABSPATH from $ file, it added to the site_url.
It should be fine.

Thanks for getting version 7.8 so quickly Katsushi, works like a charm now

Thank you for the quick advice.
As victims does not increase, it will remove the 7.7.