Feedback is welcome!

  • ResolvedPlugin Author Stonehenge Creations

    (@duisterdenhaag)


    5 years, 11 months ago

    Hi everyone,

    Thank you very much for trying out this plugin! The current version is 1.1 and that’s the initial release. On my test and live blogs I tested it and it seems/seemed ready for release.

    If you do find anything, please let me know so I (or together) can work on making it better until it’s perfect.

    I know there are some issues with the [locations_map], but any feedback is much appreciated.

    Please feel free to open a new topic if needed. ??

    Thanks,
    Patrick.

Viewing 5 replies - 1 through 5 (of 5 total)

  • Hi,

    why my page is displaying like this

    OpenStreetMap tiles not loaded despite being received

    can you pls check the screenshot

    https://i.stack.imgur.com/WGCeX.png

    Plugin Author Stonehenge Creations

    (@duisterdenhaag)

    Could you please start a new topic for this?

    Also please include a link to your live site. That tells me more than just a screen shot ??
    Thanks

    Hi,

    Some feedback after doing a short audit for including it in our page.

    (1) Where did you get minify_js from? I just spotted several bugs looking at the source code.

    (2) You are polluting the global scope a lot with JS variables (mapTiles, …) which can lead to plugin conflicts that are really hard to debug

    (3) I suggest you move the auto-generated JS code to a separate JS file. In that file, you define a JS function (e.g. output_events_map(settings)). In your PHP code, you only generate a short script that calls that function:
    echo ‘<script>output_events_map(‘ . json_encode($settings) . ‘)</script>’;

    Other than that, it is a great plugin ??

    Plugin Author Stonehenge Creations

    (@duisterdenhaag)

    If you had really looked at the code, you would have noticed that it needs the separate js to be able to display multiple maps. That is why the variables are outputted separately.

    I had a look at the code. You can achieve this easily by not putting the variables in global scope but in a function scope.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Feedback is welcome!’ is closed to new replies.