Featured image not attached to parent duplicate

The fact that this is random is going to make debugging extremely difficult.

And the fact that it happens randomly on only the production server makes it much worse.

I “hope” others who have the same problem, if any, can help out with the steps needed to reproduce consequently. Any associated debug dumps are extremely helpful.

Thank you for the fast reply,im trying to investigate using the production database and the log i got from test env.

Atm there are a few things that gave me an hint, i tried to write you by mail,i can write it all here or wait for your reply.

Cheers (my email address start with cavalletti@) ??

Hello,

after some debugging around i noticed that in \threewp-broadcast\src\traits\broadcasting.php:

– Line 620 ~ 630

On line 628 you are setting $o->attachment_data->post->post_parent = 0; before actually copying the attachment (which is just few lines later) and even then you are not assigning the post parent to the newley created attachment post.

Adding something like:

wp_update_post(array(
							'ID'			=>	$o->attachment_id,
							'post_parent'	=>	$bcd->new_post[ 'ID' ]
						));

Makes the newly created attachment post (on child blog) having a correct post_parent, dunno if its the best way to work with your plugin but at least this fix one problem.

About the replication issue i still didn’t manage to reproduce the bug but i would suggest about adding some sort of more strict control when you are about to create a new line inside wp_x_posts.

Another nice thing would be to avoid copying images if they already exist. Let me explain: if you have an image lets say in [upload_dir]/sites/x/2015/1 and you use it again in March then you are going to have that image replicated again inside the same blog. Ofc this is even more true across blogs.

What do you think about this?

What version of BC are you using?

And your existing images thing has been solved a while ago: as long as the image is registered as a media upload, and the image has the exact same name, then the duplicate will be found and used. There’s a setting for that.

I think i managed to reproduce the issue (or at least part of it). The problem is all around ‘post_name’ inside db

I’m using version 16 on production, running some tests before upgrading to 17.1.

I’m currently using the “use existing attachment on child blog” option,that’s why i wrote it here afterall.

My last thought is the following.
Lets take

• b1,b2,b3 as blog1,blog2,blog3
• p1,p2,3 as post1,post2,post3
• myimg[x] as the featured image im trying to broadcast
• ‘mytitle’ as the post_title for the attachment images (this happens in our case when our online newspaper is talking about the same things,think about names such ‘police’,’fire department’ …

Now the procedure:

1. On b1 i create a brand new post (P1) uploading for the first time ever [myimg] as the featured image using as img title “mytitle”
2. On b1 again i create another brand new post (P2) uploading another img which has the same file name as the above one,so [myimg] as the featured image and using again the title “mytitle”
3. Since wordpress puts in wp_x_posts ‘post_name’ the slug of the [image filename] and since two equal ‘post_name’ can’t exist, wordpress is going to suffix _[x] to the newly created which is now going to be,for example “myimg_1”
4. On b2 we do the same thing as step 1 always using [myimg]. On b2 that image is now going to have the post_name (slug) set to ‘myimg’.
5. We now broadcast from b1 to b2,b3 our second post P2. The result in b2 is that we have a duplicated media image since it checks for post_name = ‘myimg_1’ which obviously doesn’t exist,too bad that ‘myimg’ exist instead and its the same image we wanted to broadcast

Another thing to reproduce the bug is to attach an image which filename and ‘post_title’ are different. When broadcasted the row inside the db of the child post has post_title = post_name which is different to his parent image. For example if the original file name is ‘myimg03032015’ and post title is ‘myimg’ the row inside db has ‘post_title’ = ‘myimg’ and ‘post_name’ (slug) = ‘myimg03032015’. When broadcasted on child it will become ‘post_title’ = ‘post_name’ = ‘myimg’ which create a bad condition.

Did u have time to reproduce this bug and think about a solution? are there any news about this?