Feature: Compatibility filter for WooCommerce Subscriptions (prevents duplicate

ask comment by email seems tha the code

add_filter( 'wpo_wcpdf_email_allowed_statuses', 'wpo_wcpdf_subscription_renewal_invoice', 10, 1 );
function wpo_wcpdf_subscription_renewal_invoice ( $allowed_statuses ) {
	$subscription_statuses = array( 'customer_completed_renewal_order', 'customer_renewal_invoice' );
	return array_merge($allowed_statuses, $subscription_statuses);
}

brake the renew process with this error:

Fatal error: Call to undefined method DOMText::getAttribute() in /var/www/vhosts/solucionesuno.com/subdomains/dev/wp-content/plugins/woocommerce-pdf-invoices-packing-slips/lib/dompdf/include/cellmap.cls.php on line 437

this breake the invoice and emails, and also i have problem with TAX that are not saved correctly in renewals orders…

i comment this code and now i am testing what is happening.

Hello Luis,
As discussed per email, this filter does not change any of the invoice contents and although it is probably the cause for the emails not being sent, it is much likely be caused by something else. The DOMText::getAttribute() error is caused by faulty HTML 99% of the time. The faulty HTML is turn is ofter an error output in the middle of a table or a very big error output in a table cell. If you go to the Status tab of the plugin, you can check the option “Output to HTML”. After you have done that, please verify that the resulting HTML is free of errors. You can check for PHP errors on the output, but also try to run the HTML through an HTML validator.

Please note that the Tax issue with renewal orders is a known issue with Subscription, you’ll have to contact WooThemes support about that.

Hope that helps!

Ewout

Hi Ewout,

The piece of code you added works, but it also creates invoices for failed payments, can it be tweaked so it doesn’t create invoices for failed payments, only for successfully completed orders?

Regards

Which code precisely?

Hi, I mean this code:

add_filter( 'wpo_wcpdf_email_allowed_statuses', 'wpo_wcpdf_subscription_renewal_invoice', 10, 1 );
function wpo_wcpdf_subscription_renewal_invoice ( $allowed_statuses ) {
	$subscription_statuses = array( 'customer_completed_renewal_order', 'customer_renewal_invoice');
	return array_merge($allowed_statuses, $subscription_statuses);
}

Any update? Does this work correctly in the pro version?

Regards

I don’t know why this would also create invoices for failed payments, I would suspect that this has to do with the main plugin settings rather than this filter. Can you try to uncheck all the emails except the completed and invoice emails in the settings?

This filter is not needed if you have the professional extension, this will list the available emails instead, so you can simply check or uncheck it.

Hope that helps!

Ewout

Thanks Ewout,

I think the problem is that $allowed_statuses includes also ‘customer_renewal_invoice’ and woocommerce sends a customer_renewal_invoice for failed payments too with a different message to warn the user about the failed payment. I have changed the code, will let you know if it works when the next payment fails.

Regards

hello Ewout

to works fine with woocommerce subscription this code must be added.

is not a good ideal include this code as part as final version?

add_filter( 'wpo_wcpdf_email_allowed_statuses', 'wpo_wcpdf_subscription_renewal_invoice', 10, 1 );
function wpo_wcpdf_subscription_renewal_invoice ( $allowed_statuses ) {
    $subscription_statuses = array( 'customer_completed_renewal_order', 'customer_renewal_invoice' );
    return array_merge($allowed_statuses, $subscription_statuses);
}

Regards

No need for that anymore ??
Since a few versions you can actually select those emails in the general settings tab!

hello

i have installed 1.5.26 (latest version) and witouht this code, i change an order “pending payment” to “completed” and invoice not was attached in email order completed email.

also the number of invoice appers good in the column in orders, but when edit the order number invoice is blank.

added this coded solve the problem.

any idea? i am using woocommerce subscription addon.

Hi! It doesn’t work straight away, you first need to select the Subscription email in the General settings.

However, your code does not affect invoice numbers (nor will the update). The difference between the number in the column and the number in the actual order may have something to do with the fact that the renewal is a separate order but still linked to the parent order (so it will display the old number there).