FALSE POSITIVE: Showing Query Monitor as not PHP 7 Compatible
-
Name: Query Monitor
FILE: /XXXXXXXX/wp-content/plugins/query-monitor/collectors/environment.php
————————————————————————————————————–
FOUND 1 ERROR AFFECTING 1 LINE
————————————————————————————————————–
131 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0 – use mysqli instead.
————————————————————————————————————–Query Monitor IS PHP 7 compatible. Your plugin inaccurately marks another top plugin as not compatible.
Please fix.
-
Unfortunately static code analysis will not be able to detect this one.
While I do agree with you in general about static code analysis, in cases like this you may be able to add some tweaks to the algorithm to avoid this.
Some of the false positives we’ve seen relate to detection of functions, capabilities, settings, and they are getting flagged.
You don’t have to stick with a stock version of the library you’re using…you can tweak the algorithm to make it smarter.
That being said, thank you for whitelisting it.
You mentioned that you had whitelisted this plugin, but the false positive still exists: Query Monitor is still coming up as not PHP 7 compatible in your latest version, 1.3.0.
- The topic ‘FALSE POSITIVE: Showing Query Monitor as not PHP 7 Compatible’ is closed to new replies.
