Escaping data output breaks layout

  • We were using the “Suffix” input to display a font-awesome icon. Now that HTML gets escaped in this input it will just display the element as text, breaking the layout of our pages.

    For now we’ve edited the plugin to no longer escape HTML from the suffix input, but that fix will break again with future updates.

    We’d like to see a global option to disable escaping HTML.

    PS we’ve also tried to replace the template file as described in the documentation, but this didn’t seem to work. (we created the file “odometers.php” in the folder “siteorigin-widgets” inside our child theme, but this didn’t change the output)

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author livemesh

    (@livemesh)

    Can you pls provide a few more details on what you are trying to accomplish? Will help if you can paste the exact code change you made and the HTML element that you are trying to insert. We will be happy to address this issue for you by thinking about possible solutions. Thanks for bringing this to our attention.

    Thread Starter Jan Pascha

    (@janpaschaow)

    We have been using the “Suffix” input in the odometer widget to display a Font Awesome icon, like so:
    https://i.imgur.com/vsI8UBb.png
    The exact value in this input is this: <i class="fa-thin fa-arrow-up"></i> %

    This has been looking like this on our website:
    https://i.imgur.com/3R9Hoqj.png
    but after the recent update it looked like this:
    https://i.imgur.com/psMdNNG.png

    We’ve been able to fix it by removing the esc_html() function on line 57 in the file livemesh-siteorigin-widgets/includes/widgets/lsow-odometers-widget/tpl/default.php:
    https://i.imgur.com/8NOY96b.png

    But of course that fix will go away when the plugin gets an update again.

Viewing 2 replies - 1 through 2 (of 2 total)
  • You must be logged in to reply to this topic.