esc_attr($title) doesn't escape quotes

Hi there,

Thanks for the notice, I’ll look into it as soon as possible.

Hi Lea,

I finally had time so sit down and check this out (took me a while though, sorry for the long delay).

The quotes are properly escaped when using the widget, and it seems to me that you’re using either the wpp_get_mostpopular() or the [wpp] shortcode on your theme. Could you please post your code here so I can take a look?

Hi Héctor

Thank you so much for looking into this.
Of course I should have said it in my original post – I’m using the wpp_get_mostpopular() function call.

Here is my code:

<?php
 /* prepare args for wpp_get_mostpopular:
  *  In order to show thumbnail - need to set thumb width and height.
  * In order to show excerpt - have to set excerpt_length.
  * In order for the posts to get our style, we set custom HTML. class names have to use one apostrophe, and be escaped  */
 $custom_html = '<li class=\'clear\'>'
     . '<article class=\'hentry\'>'
     . '	<span class=\'image-wrapper\'>{thumb} </span>' /* span needed for class image-wrapper. not goog, but necessary*/
    . '	<section class=\'entry-body\'>'
    . '		<header class=\'entry-header\'><h1 class=\'entry-title\'><a href=\'{url}\'>{text_title}</a></h1></header>'
    . '		<div class=\'entry-summary\'>{summary} </div>'
    . '		<footer class=\'entry-meta\'>{stats}</footer>'
    . '	</section>'
    . '</article>'
    . '</li>';
  $wpp_args = 'limit=4&range="all"&thumbnail_width=' . TEENY_WIDTH . '&thumbnail_height=' . TEENY_HEIGHT . '&excerpt_length=' . TAB_EXCERPT_3_ROWS . '&stats_date=true&stats_date_format="F j, Y"&post_html="' . $custom_html . '"';

   wpp_get_mostpopular($wpp_args);  ?>

Thanks, Lea. I believe I’ve managed to fix the problem just now. Could you please try the latest beta and provide feedback?

Please follow these steps to upgrade to 3.0.4:

1. Backup your site’s database (if you don’t know how, please check with your hosting for support first).
2. Go to wp-admin > Plugins and disable WPP.
3. Download WPP 3.0.4 beta 5, extract its contents and replace the files in wp-content/plugins/wordpress-popular-posts with the ones from the zip file using an FTP program (such as Filezilla).
4. Go to wp-admin > Plugins and enable WPP once again.

Hi Hector,

Thank you so much! It helped!
I’m a programmer, so if you could explain how you fixed the bug, I would be very interested to hear (I looked over the code, but there are so many differences, that I’m not sure what exactly was the bug fix for this ?? I do see that you used the site’s charset. Is that part of the solution?)

Again, thank you!

Hi Lea,

Again, another late reply hehe. I’m truly sorry, I’ve been quite busy with work projects. Took some time this weekend to actually read what people have been posting here.

Anyways, I don’t remember the exact thing but it was an encoding issue indeed. Since I’m away from the computer now, once I’m back home I’ll post the relevant commit here so you can see what was done to fix the problem.

As promised, this and this were the changes made to fix the encoding issues.

The modifications made to the __format_content function are the ones that you’re looking for. The plugin was encoding the characters there and later on it decoded them again, breaking the atl/title attributes when special characters such as the single/double quotes were present in the string (post title).

Hi Hector,

Thanks for the explanation!
However, I upgraded to the latest release, and the problem is back again. Does that make sense?

Thanks!

However, I upgraded to the latest release, and the problem is back again. Does that make sense?

That’s actually odd. This is the HTML output I get using your code on the Twenty Thirteen theme:

[Removed sample code, forum parser encodes it…]

The title attribute in the img tag is properly encoded on the HTML block above, but on your site it isn’t. That’s quite puzzling.

Are you using a caching plugin, by any chance?

Hi Hector

I finally got around to trying what you did – using my code on the Twenty Thirteen theme. But it still has the same problem.
You can take a look here:
https://dev.linux.ort.org.il/kamoha/?p=26834
At the bottom, on the image of the bonfire, firebug will show you that the attributes are all jumbled…

Hi Lea!

I can’t see a reason why the attributes are messed up on your site like that. I just checked again on my localhost and the titles are correctly converted to HTML entities (see screenshot, I even used the same title).

Does that still happen if you disable all of your plugins (except WPP)?

Hi Hector

I just disabled all plugins. Still happens…
Do you want access to my site? Is there anything you could check there?

Hey Lea,

Before that, try the latest Beta release and see if it fixes the problem (do not uninstall WPP, just disable it and install the current Beta version). If it doesn’t, I might need your assistance again.

Hi Hector,

Sorry, doesn’t help ??

I created a user for you, same details as last time.
Thank you very much for looking into this!

Alright, I’ll pay your site a visit later today ??