• Resolved fidoboy

    (@fidoboy)


    There is a javascript error when displaying the widget and the author image size is wrong. Also the checkbox for “show next quote link” doesn’t work. If I uncheck that option it’s not being saved.

    Previous version was working. This release is very bad

Viewing 15 replies - 1 through 15 (of 21 total)
  • Thread Starter fidoboy

    (@fidoboy)

    There is javascript errors. But not sure why. I do not wan’t any javascript loaded because I was not using any ajax function for the quotes. Please, fix the javascript or remove it.

    • This reply was modified 1 year, 11 months ago by fidoboy.
    Plugin Author oooorgle

    (@oooorgle)

    What error is JavaScript giving you?

    “author image size is wrong” What exactly do you mean?

    I am working on fixing the Options not being saved. All the show options are having the same issue. This will be fixed in the next update. Thanks for the heads up on that!

    • This reply was modified 1 year, 11 months ago by oooorgle.
    Plugin Author oooorgle

    (@oooorgle)

    I got the options working and I think I know what you are referring to with the images. The image min-width and min-height styling will be removed in the next update. If you have further suggestions regarding the images do reply.

    I am not getting any JS errors so far.

    Thread Starter fidoboy

    (@fidoboy)

    Yep. The settings on the widget are not being saved.

    And I’m having a javascript error that was not there in previous version. It happens on page load and comes from quotes-llama.js I’m not sure about why is this script being loaded if I’m not using AJAX. I believe that you should add as an option to not load it always if it’s not needed.

    Not sure about the issue with the image size. I can’t solve it or change the size to a smaller one.

    Thread Starter fidoboy

    (@fidoboy)

    May be the issue is that the image size is being hardcoded into the <img> tag?

    Plugin Author oooorgle

    (@oooorgle)

    Can you copy and paste the JavaScript error? Just saying there is an error doesn’t lead to any actual place to look for it.

    Thread Starter fidoboy

    (@fidoboy)

    Here it is:

    Uncaught TypeError: e.indexOf is not a function
    at S.fn.load (jquery.min.js?ver=3.6.3:2:85207)
    at quotes-llama.js?ver=1.3.2:104:163

    I also found that the author image is wrong, or just different from previous versions. It is larger which crowds the container in Elementor and makes spacing off by just enough to cause a problem

    Plugin Author oooorgle

    (@oooorgle)

    The image styling will be reverted to previous version in next update. The plugin could seriously use a CSS expert, that which I am not. My apologies.

    Plugin Author oooorgle

    (@oooorgle)

    I had one .load call which I found was deprecated in jQuery 3.0. This has been updated in 2.1.1. Let me know if it fixed or not?

    Thread Starter fidoboy

    (@fidoboy)

    For me the best solution is to remove the javascript completely on frontend, because I’m not using any AJAX functionality. All works fine if I completely remove the javascript.

    Plugin Author oooorgle

    (@oooorgle)

    Are you still getting the same error?

    I wonder if I’m encountering a related error – updated from 2.0.9 to 2.1.1 and a smidgen of the text on the right-hand side is wiped out, as if by a phantom white border.

    Plugin Author oooorgle

    (@oooorgle)

    Hi Spinweb, are you able to share a link exampling the problem you are experiencing?

    Plugin Author oooorgle

    (@oooorgle)

    Fidoboy, The entire plugin beyond pulling in a simple static quotes relies on AJAX functionality. Others do use it. I would break most aspects of the plugin by removing that. Next quote link, gallery, auto, and page modes would not exist for a few examples.

    What I need to do is separate the wp_enqueue_script based on short-code or widget setting. Not sure how yet though. I don’t want unnecessary code loading where it’s not used either, but removing jQuery for the entire plugin isn’t an option. I will look into separating the scripts and see if I can get it working. That would be sweet to say the least.

    However, if you are still getting JavaScript errors, it should be addressed and fixed. Do copy/paste any that you are still getting. Otherwise I’ll assume that the update addressed that particular error.

    Again, thanks for all the suggestions that have helped work out the bugs and improved this plugin immensely.

Viewing 15 replies - 1 through 15 (of 21 total)
  • The topic ‘Error in latest update 2.1.0’ is closed to new replies.