Error code 500(Internal Server Error)!!!

hmm … could you uncomment and change

$tmp_code = trim (CssMin::minify($code, false));
into
$tmp_code = trim (CssMin::minify($code));

and see if that solves that problem zerooverture?

frank

yes, is ok!!
thanks!you are good~

OK, I’ll make sure this goes in the next release. Thanks for your feedback!

Thanks for this update. My 27 blog multisite disappeared on updating to version 1.93. On amending the above code (actually line 358) everything appears back to normal on network activation.

Anyway, an excuse to have a fortifying scotch to settle my nerves first thing in the morning here in Australia…

Cheers,

Tony Page

sorry about that Tony! hope you enjoyed the scotch though ??

frank

A bit of background-info maybe;

AO ships with 2 CSS-minification components. Depending on configuration it loads the default one (YUI CSS compressor PHP port) or the other (the legacy one, from an old versoin of Mr Clay’s minify, exceptionally, if the AUTOPTIMIZE_LEGACY_MINIFIERS constant is set).

Now while trying to decide which CSS minification component to load, AO also checks if there is already a CSS minification-component active (from the theme or another plugin). If there is, AO does not try to load it’s own CSSmin-instance (which would cause an error as well), but uses the existing one. This is the case here, with the external-to-AO CSSmin not expecting/ accepting the 2nd parameter.

The error was due to a mostly “cosmetic” change proposed by a contributor on GitHub and seemed OK when testing. Except it couldn’t pop up in tests, as this only occurs if the specific (version of the) external CSSmin component provided by the theme or another plugin doesn’t expect that 2nd parameter.

That’ll teach me not to try to fix things that aren’t broken ??

frank