Empty div if no meta is displayed

  • Hey!

    Me again ??

    I noticed that the div.ptam-block-post-grid-byline is output even if it’s empty.
    I configured the block to “just” display the title, excerpt and read-more link. Therefore there is no need for the empty div.

    Can imagine that it makes sense to have a empty div if one of the items displays has some value to be shown. If the byline is disabled for the whole block I think the div is not needed.

    What do you think?

    Greetings
    derRALF

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Ronald Huereca

    (@ronalfy)

    @drivingralle fixed with https://github.com/ronalfy/post-type-archive-mapping/issues/29.

    Thread Starter Drivingralle

    (@drivingralle)

    Hey!

    I have updated to the latest Version from the WP Repo. The empty div.ptam-block-post-grid-byline still shows up.

    I placed the block here:
    https://www.cross-media-cloud.de/leistungen/schulungen/
    with the following settings:
    Screen Shot

    Not sure why the empty div is still part of the output.

    Greetings
    derRALF

    Plugin Author Ronald Huereca

    (@ronalfy)

    @drivingralle have you disabled custom fields as well?

    Thread Starter Drivingralle

    (@drivingralle)

    Hey!

    1. Test: Disable all things. No title. No image. No custom fields. No “options” section. Save. Refresh: Nothing to see from item as expected. Markup for block wrapper, grid and item present. Inside the item an empty p.ptam-block-post-grid-excerpt tag.

    2. Test: Enable Title. Save. Refresh: Title shows up ??. Inside the item an empty p.ptam-block-post-grid-excerpt tag.

    3. Test: Enable custom field section. No content in textarea. Safe. Refresh: No div.ptam-block-post-custom-fields shows up ??. Empty div.ptam-block-post-grid-byline and empty p.ptam-block-post-grid-excerpt.

    4. Test: Add test inside textarea for custom fields. Save. Refresh: div.ptam-block-post-custom-fields is shown with text inside ??. Empty div.ptam-block-post-grid-byline and empty p.ptam-block-post-grid-excerpt.

    —–

    I know I’m very picky ??

    Greetings
    derRALF

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Empty div if no meta is displayed’ is closed to new replies.