• Resolved Oliver Campion

    (@domainsupport)


    Hi,

    Just seen this in our error.log …

    E_WARNING: date() expects parameter 2 to be int, string given in /wp-content/plugins/merge-minify-refresh/merge-minify-refresh.php?on line 315

    Not 100% sure what the circumstances were surrounding this but I suspect it happened when “Purge All” was pressed. Looks like you need to change line 313 – 316 to …

    elseif (absint($accessed))
    {
    $accessed = date(get_option('date_format'), $accessed);
    }
    else
    {
    $accessed = 'Unknown';
    }

    Kind regards,

    Oliver

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author launchinteractive

    (@launchinteractive)

    Hi Oliver. This error would show up if the WordPress date format isn’t set correctly. You can fix it by going to Settings > General > Date Format in WordPress admin.

    I have also rolled out a release so it shouldn’t be an issue anymore.

    Thread Starter Oliver Campion

    (@domainsupport)

    Thanks for this but I’m afraid that’s not what’s going on here. The error is for parameter 2 of the date() function which is required to be an integer.

    The issue arrises when line 293 …

    $accessed = file_get_contents($script_path . '.accessed');

    … fails to return a unix timestamp as expected (for whatever reason).

    Please take another look at my recommended fix.

    Thank you.

    Oliver

    Plugin Author launchinteractive

    (@launchinteractive)

    Oh yes, sorry I misread that. I’ve pushed out a new version that adds your fix.

    Thanks.

    Thread Starter Oliver Campion

    (@domainsupport)

    Awesome, thank you.

    By the way, is there any reason you use “trunk” as the “Stable tag” in readme.txt rather than an actual tag? I only ask because I found it hard to find your previous version to compare changes as a tag for each version doesn’t exist since v1.12.

    Plugin Author launchinteractive

    (@launchinteractive)

    There isn’t any reason why. That’s how it was originally set up and I never bothered to change it. I might change it next release.

    Thread Starter Oliver Campion

    (@domainsupport)

    OK, thanks. And sorry, I didn’t realise you had inherited the project.

    Plugin Author launchinteractive

    (@launchinteractive)

    Ahh.. naah. I didn’t inherit it.. That’s just how I set it up years and years ago ??

    Thread Starter Oliver Campion

    (@domainsupport)

    Oh haha! ??

Viewing 8 replies - 1 through 8 (of 8 total)
  • You must be logged in to reply to this topic.