• Resolved KTS915

    (@kts915)


    I am trying out a few Invoices plugins, and have just installed yours. But I notice that it immediately takes it upon itself to decide what columns are available to be shown on the Users screen on the admin pages.

    I consider that very bad manners.

    By all means make your own custom columns available to be shown — but along with all the other columns made available by core and other plugins. Then let me, the user, decide which ones I want to actually see. That’s what the Screen Options tab is for.

    I hope you will address this soon. The relevant functions begin at line 425 of the current version in /admin/includes/sliced-admin-columns.php

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author SlicedInvoices

    (@slicedinvoices)

    Well, you’re right. Our intention here was simply to *add* our custom column, but I see the code you referenced can actually remove other plugins’ columns in the process. We don’t want to do that.

    I’ll make sure a fix for this bug is included in the next update of Sliced Invoices. Sorry for any inconvenience.

    Thanks,
    David

    Plugin Author SlicedInvoices

    (@slicedinvoices)

    FYI I’ve just released that update as version 3.2.1.

    Thanks,
    David

    Thread Starter KTS915

    (@kts915)

    Thank you! The columns are indeed back now.

    Unfortunately, it seems the priority you use is still causing the content in the fields placed by the other plugins I use (s2Member and Reveal IDs) to be blank. But I can get them all to play well together by changing this line:
    add_action('manage_users_custom_column', array( $this, 'add_custom_user_columns'), 15, 3);
    to this:
    add_action('manage_users_custom_column', array( $this, 'add_custom_user_columns'), 9, 3);

    Thanks again!

    Thread Starter KTS915

    (@kts915)

    Trying out your plugin further, it seems that you also prevent Reveal IDs from showing the ID number of each quote and invoice on the respective edit.php screens. I haven’t found what your specific code is that doing this, but I would like to see those IDs!

    Plugin Author SlicedInvoices

    (@slicedinvoices)

    I’m not familiar with the reveal ids plugin, but I’ll test it out and try to see what the conflict is.

    Also at the moment it doesn’t make sense to me why the other plugins columns would be blank, or why changing the priority of our hooks would have any impact on them… That has me puzzled. I’ll try it in combination with s2member and see if I can figure that out.

    This might take some more time than the last update, please stand by…

    Thread Starter KTS915

    (@kts915)

    it doesn’t make sense to me … why changing the priority of our hooks would have any impact

    I agree: I’m puzzled too. But I’ve seen it happen with other plugins too.

    This might take some more time than the last update, please stand by…

    Sure — I understand.

    Plugin Author SlicedInvoices

    (@slicedinvoices)

    I have fixes for both issues now.

    For the blank columns on the users page, the problem was in function add_custom_user_columns() where we omitted to return $value at the end of the function. That meant any custom columns added *before* ours in the order of execution would be blanked out. And that’s why changing the priority seemed to fix it — allowing the other plugins to add their columns *after* ours.

    The missing custom columns from the edit.php screens was the same as the problem with the Users page, just in a different place in the code.

    Anyway, both fixes will be released in the next update, along with some other updates I’m working on, tentatively scheduled for next Sunday (Jan 29th). However if you want the update sooner I can email it to you in advance, just let me know.

    Thread Starter KTS915

    (@kts915)

    Great! I am happy to wait; I’m already impressed by your responsiveness and openness.

    Plugin Author SlicedInvoices

    (@slicedinvoices)

    Hi again, I just released the update in question, v3.3.0. Please give a try when you get a chance, and let me know…

    Thread Starter KTS915

    (@kts915)

    Just tried it out, and it’s working perfectly! Thank you! Now I can see what I’m doing when I try different things!

    I will probably have a couple of questions after I have finished my testing, but I’ll start a new thread for those. This one is resolved.

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Don’t re-write the columns on users.php!’ is closed to new replies.