Doesn't process payment with wc 2.2 and wp 4.1

The plugin works with WooCommerce 2.2.x, but we haven’t tested it on WordPress 4.1 yet. The WordPress update was recent and we didn’t have the time to give it a try (we don’t run tests against Beta versions).

If we will spot any issue with WordPress 4.1 we will certainly address it. However we cannot say when we will release the next update, as this is a secondary project and we have many others open. We will look into it ad soon as possible.

@yeray By the way, there’s one important information in the snippet of log you posted:

12-22-2014 @ 16:14:55 - Skrill arguments (JSON):

For some reason, the data posted back by Skrill arrived empty, which means that the order payment could not be validated. Technically, the plugin did its job as it’s supposed to (empty data = no payment validation). It will be interesting to find out why that happened.

@yeray I asked to make some tests with the following configuration:

• WooCommerce 2.2.10
• WordPress 4.1
• Skrill 1.2.14.141218

Everything worked fine. Payments were processed via Skrill and the orders were correctly updated to reflect this.

If you wish, you can verify this as well by using our development site: https://wc-demo.aelia.co. Simply place an order for any product. Make sure that you create an account at checkout, so that you can log back in using the My Account link after payment and see that the order is in “Processing” status.

If you need a test card number to use Skrill, simply drop us a line. Please note that we are closed for Christmas until the 29/12 and that it might take some time for us to reply. Thanks.

Hi, thanks for your help.

I was looking at the code of the plugin, and I think the log line Skrill arguments (JSON) is not generated with the response but with the parameters sent to Skrill (The response would be on Posted data (JSON)).

It’s on line 699 of class-wc-gateway-skrill.php:

$this->log(sprintf(__('Skrill arguments (JSON): ', $this->text_domain), json_encode($skrill_args)), true);

The strange thing is, if I do a

$this->log(json_encode($skrill_args));

it will show the arguments correctly. Maybe there is a problem in that line? I think our problem is not there anyways, but maybe you want to take a look at that…

The JSON with the information sent to Skrill is this:

{“pay_to_email”:”[email protected]”,”language”:”EN”,”currency”:”EUR”,”return_url”:”https:\/\/ourcompany.com\/checkout\/order-received\/1977?key=wc_order_54ad69c54c8f9″,”cancel_url”:”https:\/\/ourcompany.com\/cart\/?cancel_order=true&order=wc_order_54ad69c54c8f9&order_id=1977&redirect&_wpnonce=38a132514d”,”status_url”:”http:\/\/ourcompany.com\/?wc-api=WC_Gateway_Skrill”,”merchant_fields”:”order_key”,”order_key”:”wc_order_54ad69c54c8f9″,”transaction_id”:1977,”amount”:”119.00″,”amount2″:”119.00″,”amount2_description”:”Order #1977″,”comments”:””,”pay_from_email”:”[email protected]”,”bcompany”:””,”firstname”:””,”lastname”:””,”address”:””,”address2″:””,”phone_number”:””,”postal_code”:””,”city”:””,”state”:””,”country”:””}

Until I get a Skrill testing user I won’t be able to test more, but I would appreciate if you can point me in the right direction with the information I’ve put there.

Regards.

Now that you mention it, there is a problem with that line. A minor one, but enough not to show the data.

Incorrect code
__('Skrill arguments (JSON): ',

Correct code
__('Skrill arguments (JSON): %s',

The incorrect code simply does not print the argument. Not easy to spot, unless someone points that out, like you did! ??

Hi.

I managed to find where the problem is. For some reason, you are calculating the status_url for Skrill like this:

line 467 of file class-wc-gateway-skrill.php
$this->status_url = str_replace('https:', 'http:', add_query_arg(array('wc-api' => 'WC_Gateway_Skrill'), home_url('/')));

We only allow https on our domain, and redirect (301) the http requests, but the Skrill guys don’t send the answer back if they get a redirect.

For now we’ve modified that line and left it like:
$this->status_url = add_query_arg(array(‘wc-api’ => ‘WC_Gateway_Skrill’), home_url(‘/’));

And it works! Is there any reason you are changing status_url to http? We can allow http to just that url if there is a reason for it.

I checked, and you’re right, the return URL won’t work if the site enforces HTTPS.

I can’t remember the reason why the URL is forced back to HTTP, but I can make an educated guess. This was one of our first attempts at creating a payment gateway and we inherited some of the code from the existing gateways. One of the is the default PayPal gateway included in WooCommerce, which, if I recall correctly, contains that string replacement. We probably copied the logic from it for testing one of the first drafts, and never spotted the issue with “HTTPS only” sites because our test sites allow both protocols. However, I don’t think there is a real requirement for the return URL to be HTTP.

I will pass on your finding and release an updated build as soon as possible. Thanks again for your effort in finding it, excellent job!