• Resolved teugene

    (@teugene)


    We are trialing this and the plugin works well so far but on pages that are built with Bricks, no glossary text are highlighted. I see that there’s already support for some well known page builders. Bricks has been around for a couple of years and it would be awesome if the team can add compatibility with it.

Viewing 9 replies - 1 through 9 (of 9 total)
  • Hi can you explain how are you using it with Bricks?
    So we can replicate it? Like you did a page template or just a page with some Bricks blocks on that?

    I found a fix but we need to testing further for all our cases.

    The patch in the meantime in the glossary-by-codeat/frontend/Core/Term_Injector.php at line 100 add:

    $this->already_found = array();

    Thread Starter teugene

    (@teugene)

    Thanks for the reply. I’m editing a page with Bricks for now. It might include a single template as well but we haven’t worked on anything like that yet.

    Based on your patch, do I add it like this at line 100?

    return (string) \iconv( 'UTF-8', 'UTF-8//IGNORE', $this->text, $this->already_found = array() );
    

    Sorry you are using the free version so the right line is 94 not 100.
    And you add it like
    $this->terms_to_inject = array();$this->already_found = array()

    Thread Starter teugene

    (@teugene)

    I’ve added the line as instructed. Still don’t see anything unfortunately.

    • This reply was modified 1 year, 11 months ago by teugene.

    In my tests works but we are investigating further what is happening.
    The issue is that the code is executed twice in the page with bricks, one in the header and one in the real content and the plugin seems that doesn’t like this way.

    For the next version I did some changes that improve the compatibility but I can’t right now do a release with those as it will be the next major.

    The new major has an improved support for page builder like Bricks (I tested it)

    The latest 2.2 branch include support for bricks builder.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Does not work on pages built with Bricks Builder’ is closed to new replies.