Does Not Scale

This site has over 360k registered users. Upon activating the plugin, it timed out as it tried to add >720k user meta keys. Not sure why it doesn’t just meta select only users who do not have the fields (which would have still timed out, but at least it would continue on the next time Activate was attempted). I “fixed” that by adding them with my own script and then uncommented the activation hook. It appeared to be working fine after that, but then I discovered (via Query Monitor) that it was adding over 6 seconds (with Redis caching!) to every admin page load because the constructor pulls a list of all unapproved users.

It would also have been nice if there was a checkbox like “Delete plugin data when uninstalled” or whatever so I didn’t have to re-add over 720k meta fields to my dev box after deleting the plugin to move it as a submodule (obviously, I should have just deleted the directory, but I didn’t look at the code and realize that it was going to asplode everything on my dev instance).

I get it – 360k+ users is a lot, but for plugins (plural: the others failed too, for the same reason) that assume a site is soliciting registrations from anon, you’d expect them to handle a lot of registrations. If you don’t have many users/registrations, you don’t really need a plugin to manage them, right?

I’m assuming that it loads a list of every unapproved user on every admin page load solely for the unapproved user count badge on the admin menu (I didn’t look – I stopped trying to hack it and just decided to tell the users to manage it manually, which was unpopular).

+3 stars because it’s free and doesn’t use Freemius.

EDIT – Also, you can change the instantiation because I don’t think it needs to run during cron or Ajax requests:
if( !wp_doing_cron() && !wp_doing_ajax() ) new Obenland_Wp_Approve_User();

You can probably check for is_admin() before running code in various places, too.

• This topic was modified 4 years, 7 months ago by Daniel Hendricks. Reason: Decided to add an extra star, because it's free
• This topic was modified 4 years, 7 months ago by Daniel Hendricks. Reason: Added note about instantiation