Do you plan to update included copy of jQuery Select2.

Hello,

I also have the conflict between Toolset Types select and woo-commerce select. The woo-commerce select breaks when i enable Toolset Type plugin. Any guidance how to over come this issue.

@adil Ali – I did some research and found that Select2 v4 is backward compatible for the most part(99%) with 3.5, so I added detection to see if it was already registered via another plugin, if so I simply unregistered and re-registered the newer version. Didn’t seem to break Types and fixed the JS errors my users were seeing.

Apologize the delay here.

Correctly @danieliser seems to have solved the problem.

I will inform our developers and ask if we can upgrade the script.

Thank you

@beda – Add to the list of reasons Accessibility. v4 addressed a lot of specific issues with accessibility in v3.5 which is basically unusable to a screenreader.

That was my prime reason for using it.

Side note, since so many other plugins haven’t figured this out yet, I ended up forcing it to load under another namespace pumselect2 since plugins like WooCommerce still using 3.5 had custom ajax functionality that breaks since v4 included this already and it doesn’t match their JS.

Sucks but I’m not going backwards just because everyone else is comfortable there ??

Sure, our DEV team already looks for solutions.

It will take some time because we need to update all common code to our Plugins since we use select2 widely.

Once this is done we will update our Changelog in regard.
Thanks for reporting it.

@beda – Awesome, 1 plugin down 99 other plugins still to convince ??

+1 guys.

Is this still in the pipeline?

Yes, I apologize, this is not yet deployed.

We updated Select2.
Mind you as example WooCommerce uses old Select2, so it might still conflict with your plugin if you use WooCommerce.
But we solved this on our end.

@bedas – What we ended up doing (until more people start updating) was to roll a custom version that can run in no conflict with another version. This way works well even with another version loaded.

Once core includes Select2 then we can safely remove that.

Here is an example if you want 100% compatiblity even with WooC etc.

https://github.com/PopupMaker/Popup-Maker/blob/master/assets/js/src/admin/vendor/select2.full.custom.js

The important bits are https://github.com/PopupMaker/Popup-Maker/blob/master/assets/js/src/admin/vendor/select2.full.custom.js#L6283-L6291 and https://github.com/PopupMaker/Popup-Maker/blob/master/assets/js/src/admin/vendor/select2.full.custom.js#L28-L30

Basically just do a search and replace on that file for pumselect2 and replace it with typeselect2 or similar. Then just call whichever is available when you initialize it:

https://github.com/PopupMaker/Popup-Maker/blob/master/assets/js/src/admin/plugins/select2.js#L5

Hope that helps.

PS if this wasn’t the admin we would never recommend this as it loads an extra copy, but in the admin it seems more appropriate to be 100% compatible than to worry about a couple extra kb of code.