“Do not display default credit” setting no longer respected

Can you provide a screenshot of the problem? From the description, I’m not sure whether you mean the “Add Media” dialog (or the visual editor) on the backend or the rendered shortcode on the frontend.

When “Do not display default credit” is enabled, the default credit (author name) is used a placeholder text, which might be what you are seeing if you’re talking about the backend. However, when you insert an image into the post content, no shortcode is added. Existing shortcodes referencing user IDs are displayed normally with or without the option (so as to not change existing content). This behavior is unchanged from the introduction of that option.

As for the feature request: You mean like a checkbox in the Media dialogs that switches the input field on and off?

Here are some screenshots: https://mcasantabarbara.org/troubleshooting/

how_normally_used.png is how it usually looks with a credit.
blank_space.png is how it used to look when no credit was entered and “Do not display default credit” was checked, and how it currently looks when I just enter a space character in the credit field
default_author.png is how it looks now that I’ve upgraded the plugin. That’s my name, which is coming from my user account. Not just in the back end, that’s the live site.
attachment_details.png is what the attachment page looks like in the back-end, where you can see my name as it appears by default and cannot be removed. Before, even though my name appeared there, no credit appeared on the live page if “Do not display default credit” was checked in the plugin settings. Now it does.

These are for Featured Images, by the way. I know I can choose to use a credit or not when inserting into a post.

I could technically go back and enter a space character for each image where this is a problem, but that’s between 50 and 100 images, which I frankly don’t have time to do right now, and it used to work fine before the plugin upgrade.

As for the feature request: You mean like a checkbox in the Media dialogs that switches the input field on and off?

Kind of, but not just that switches the input field off but prevents any media credit from displaying on the page even though one may exist for that image. Again, mostly talking about “featured” images here.

Hope that all made sense.

Thanks, now I know where to look. I changed some parts of the featured image filter to fix the nested link problem. It looks like I may have accidentally removed the check for the Do not display default credit option in that function.

As for the feature request, I am not sure what the usecase would be?

Cool, thanks for looking into this.

For the feature request, this really only affects featured images, I guess. Right now, media credits for featured images are either globally on or globally off. We use a lot of images that need artist/photographer credits since we’re a museum (and I really wish default WordPress included some reasonable functionality for that, though your plugin works best of the options I tried so far), but sometimes we want to use an image that doesn’t need a credit for one reason or another. For instance, if it was taken by a staff member, or if it’s actually a graphic produced internally. For example: https://mcasantabarbara.org/?event=curated-cocktails&event_date=2017-02-02. That curated cocktails logo is something we produced, and we really don’t need to credit ourselves for it (we’re not narcissists, after all). Since there’s no way to turn off media credits for an individual featured image, and we still need to use credits for others, there’s an annoying gray box under this one even though it’s blank/uses a space char. Our theme uses the featured image as a header in the widgets you see here: https://mcasantabarbara.org/events/upcoming-events/ (and I had to hack some CSS so that the media credit didn’t appear in the widgets as well). Using both a featured image and an inserted image isn’t really an option. I’m trying to keep weird workarounds to a minimum since others have to be able to update the site as well.

Basically I’m looking for a way to locally turn off media credits for individual featured images. Or, the space the credit would normally occupy on the page should completely disappear if no media credit input text has been entered in the back-end. Either one would solve the issue for me.

Thanks.

Oh, and Re: test case, the media credit bar also appears under images in our (not currently live but upcoming) web shop. Those won’t usually need a credit either. I could technically set the background of the media credit bar to white, but the powers that be specifically wanted it gray, so…

OH, sure, when there is no visible string, the credit should be hidden for featured images. That’s actually a bug (that it currently isn’t).

As for the web shop, if it’s in the same site as your regular stuff, how about simply hiding the credits via CSS? Or using the template tags provided by the plugin to integrate media credits with special conditions into your templates, (that’s what I’m doing on my personal blog, as it allows a much deeper integration with the theme)?

Both issues should be fixed in 3.1.6.

Hi again.

Sorry, just got back in the office. I was able to install the new version and test. Seems to work great now!

Thanks a bunch!

Thanks for reporting the bug(s)! If you like the plugin, it would be great if you could find the time to write a review ??