Thank you for posting the PHP source code for your item values filter. You can imagine my embarrassment when I saw it and realized that the filter was the source of the problem; I should have picked up on that much earlier! It says:
* Compose a new caption with a “clickable” document title.
Which, of course, overwrites the value created by the mla_caption="Size: {+file_size,commas+}" parameter in the shortcode. I regret the delay and extra effort caused by my failue to think things through.
Here, then, is an updated version of your filter which you can adapt to get the caption you want:
public static function mla_gallery_item_values_filter( $item_values ) {
/*
* For this example, we will reformat the 'date' value as d/m/Y. We use a shortcode parameter of our
* own to do this on a gallery-by-gallery basis, leaving other [mla_gallery] instances untouched.
*/
if ( isset( self::$shortcode_attributes['my_filter'] ) && 'format date' == self::$shortcode_attributes['my_filter'] ) {
/*
* Default format is YYYY-MM-DD HH:MM:SS (HH = 00 - 23), or 'Y-m-d H:i:s'
* Convert to UNIX timestamp so any reformat is possible
*/
$old_date = $item_values['date'];
$timestamp = mktime( substr( $old_date, 11, 2 ), substr( $old_date, 14, 2 ), substr( $old_date, 17, 2 ), substr( $old_date, 5, 2 ), substr( $old_date, 8, 2 ), substr( $old_date, 0, 4 ) );
/*
* Update the $item_values and pass them back from the filter.
*/
$item_values['date'] = date( 'd/m/Y', $timestamp );
/*
* Compose the file size in different formats.
*
* You can use MLAOptions::mla_get_data_source() to get anything available.
*/
$my_setting = array(
'data_source' => 'file_size',
'option' => 'raw'
);
$file_size = (float) MLAOptions::mla_get_data_source($item_values['attachment_ID'], 'single_attachment_mapping', $my_setting, NULL);
if ( 1048576 < $file_size ) {
$file_size = number_format( ($file_size/1048576), 3 ).' MB';
} elseif ( 10240 < $file_size ) {
$file_size = number_format( ($file_size/1024), 3 ).' KB';
} else {
$file_size = number_format( $file_size );
}
/*
* Compose a new caption with a "clickable" document title, date and file size.
*/
$item_values['caption'] = sprintf( '<a href="%1$s">%2$s</a> <span class="info"><a href="%1$s">%3$s</a></span><br>Size: %4$s', $item_values['file_url'], $item_values['title'], $item_values['date'], $file_size );
}
return $item_values;
}
Note that in addition to adding the size information I have moved the return $item_values; statement outside the if test for your my_filter="format date" parameter. That’s required so any [mla_gallery] shortcode that does NOT contain the parameter will continue to work.
Now that the filter is doing all the work you can remove the mla_caption parameter from your shortcode(s).
Thank you once again for your patience in getting this issue identified and fixed. I am marking this topic resolved, but please update it if you have any problems or further questions.
