Disorder sentence by using popup

@milestone – Could work, problem is it would never look right in the editor, only once saved and rendered. But you are correct, unless I have missed an option in WP but I don’t think thats it, basically inline shortcodes likely can’t be rendered/preview.

It will ultimately take updates to the core editor views system to make it work correctly.

@stokertje – I can duplicate it, but I get the feeling that the feature is seldom used and less often in the way you are so likely just not surfaced for enough people. That said it wouldn’t surprise me at all if the other users who have this issue saw the solutions provided above and just chose to use them rather than posting. I am working to resolve it but its a complex issue that needs to be solved correctly since there are likely to be many other plugins with similar issues in the future when they begin adding preview rendering for their shortcodes (eventually all shortcodes will render in the editor in this way, we are just a few years ahead of the curve).

Hi,

I installed and tested the next plugins :

– Popup Builder
– POpup – WP Popup
– popups WordPress Popup
– WordPress Popup

All those eplugins have no problem with the wordpress editor.
Realize that the problems started after the last update of popupmaker.

For now i have 158 popups. To copy them towards an working plugin is to handle. Only text; terms and defenitions.

But to redefine all the terms and defenitions in the text and all webpages. …..oi…that is a lot of work.

So the situation is that a perfectly working pluging has troubles after an update with the standard wordpress editor.

So what are my options ?

regards Jan

@stokertje – If this is a great problem for you then why not roll back to the previous problem-free version? On the main WP plugin page, there is a menu item called Developers. Go into that andf you’ll see all the previous versions. Download your chosen one and upload it (still as a zip file) using the ‘add new’ button on your plugins page. And don’t update it until @danieliser says the WP problem is fixed!!!

@danieliser – Yep, its a very temporary ugly kludge and could only work on already saved posts/pages. But it would dig people who can’t feasibly correct a site full of popups out of a hole. If WP core creates the paragraph breaks, then only some form of grep (internal or external to your plugin) will help.

Hi Milstone,

Thanks for your contribution.
Quite enthousiastic i hoped tht installing an older version woeld solve the problem.

I installed several versions of the plugin of the 4.XX range. Unfortunaly they all give the popupmaker button with teh same problem.

So I installed version 1.3.9…..that gives an fatal crach….oeps…

So…what could i doe now ?

Regards Jan

@stokertje – Did you try adding the line of code I gave earlier? It completely disabled the shortcode editor which should do just what your after since it also would disable the live previews which causes the issue your having.

Just to clarify, yes it is an issue, but for 99% of our users it is a non-issue because they can simply work around it. In your case with hundreds of popups that wouldn’t be the case. I completely understand that. But you seem to be missing that what your seeing isn’t actually a bug at all in the since that it can be patched and fixed.

It is a design flaw in the WordPress editor itself that we cannot get around, that said I am exploring options to do so, but do not see going backward as an option, I would much rather bring the issue to the WordPress core team and get it fixed correctly. In this case it only seems to be negatively impacting one or 2 users out of 50,000, and there is an alternative in the mean time so as to actually changing anything in the plugin at the moment, I am very hesitant to do so as it won’t really fix anything, just leaves it for the next plugin developer to deal with.

So to boil it down, likely won’t be removing that feature, but will continue to work on an actual resolution. In the mean time add this line of code to your themes functions.php file (Appearance -> Editor -> Theme Functions file) and it will disable the shortcode editor allowing you to do it the way you did before.

remove_action( 'admin_init', array( PUM_Admin_Shortcode_UI::instance(), 'init_editor' ), 20 );

Hope that helps.

Hi danielser,

Sorry fore my bad communication.
Of course I tried the code: but it the theme crah with the code in a test environment. So i switched towards the wel-known theme like twenty firtheen and so on.

Aso the them crahes or wont start up….

So….seems like a showstopper….-:(

@stokertje – Sorry about that, I tested it and it worked but it did log an error that I overlooked. Here is an updated function that resolves both the error and disables the shortcode button successfully.

https://gist.github.com/danieliser/ef4d341fd154ce78f1ac69c71860ffc1

Hi,

When I use the code nothin wil happen.

Whe i skip the text:
<?php
/** Copy everything below here to your functions.php file */ an copy the next text in themefunction

add_action( ‘after_setup_theme’, ‘remove_pum_shortcode_ui’ );
function remove_pum_shortcode_ui() {
if ( class_exists( ‘PUM_Admin_Shortcode_UI’ ) ) {
remove_action( ‘admin_init’, array( PUM_Admin_Shortcode_UI::instance(), ‘init_editor’ ), 20 );
}
}

it wil crash…..

Is it an option that I give you admin rights into the test environment ?? So you ca test it yourself ?? its is an test environment so nothing will happen…

Maybe the best thing to do?

Regards Jan

Helllo,

The isseu is not resolved.

Please help me to solve this isseu or to create a situation towards the WP-Soluton.

The code doesn’t work.

Is it wise you get an admin account so you can see for yourself what is hapening ?

regards

Jan

@stokertje – If you copied the <?php part that would break it, which is why the comment says everything below that line.

That said you can submit temporary credentials to https://wppopupmaker.com/support and I will definitely take a look and disable it.

Hi Danieliser,

I created an aadmin account in the test environment.

I sent it as asked in the support

Regards Jan

I’m having the same problem, please post when you have the solution for this

Great !

I’m happy i’m not the only one …

…

@stokertje – Try it now. Just for your info in the future, I’m not sure if you copied the <?php part to your theme file, but you don’t want to do that, it will definitely cause breakage.

You should only copy the lines below the —- line in that example.

I added it to your themes functions.php file and the editor no longer has the PM Shortcode button and you can now manually insert the trigger shortcode safely without line breaks.

@joserd – If you have to many shortcodes to manage you can use the solution here.

Otherwise you can use the text editor to remove the line breaks until a long term solution for the Shortcode button rendering issues is found.

Thanks @danieliser, I’ll try it tomorrow first hour and will let you know on how it went