Disorder sentence by using popup

click here for the site

@stokertje – Hmm, that is the first I have seen the extra lines added on the front end. Looking into fixes for you. You can fix it manually using the text tab of the editor for now.

The problem is the visual previews for shortcodes don’t currently allow for inline display(part of wordpress not part of popup maker), hence it shows on its own line. Though that shouldn’t effect the way it looks on the front end.

Either way looking into it.

Hi,

Thans for your reaction

Can you help me with your suggestion to fix is manually ?
How do I use the text tab or editor ????
Do you have an example or documentation ?

Maybe you need an admin ?

Regards Jan

Hi,

as asked i tried manualy with textab and other things. No results..

I even changed the theme; no results so I installed my regular theme back.

Maybe info for you: it all started after the update.

I have abot 150 popups so I hope you can solve the problem asap…-)

regards Jan

@stokertje – The issue isn’t with the popups, but the how the editor treats new lines. Take this example:

Some [popup_trigger]Text[/popup_trigger] on a line.

That will render fine. But WordPress translates empty lines into new <p> tags, for example:

Some

[popup_trigger]Text[/popup_trigger]

on a line.

Gets converted into 3 separate paragraphs. That not something we can do anything about directly. I will have to likely disable the visual previews for the popup triggers for now to resolve it.

Looking into it but you can fix it now using the text tab by removing the extra lines making the trigger part of the same line as the text before it and after.

Hope that helps.

Hi,

May I conclude

1) That the popupmaker doesn’t work properly anymore ?

2) That the plugin doesnt work in the regular wordpress editor ?

3) That the plugin doesn’t work with wordpress theme’s ?

My question: when is the next update when you solve this isseu ?

Regards Jan

@stokertje – None of those are true to be honest. I can see there is an issue with the shortcode previews causing new lines, but it by no means breaks everything.

As I said before the issue is only with the popup_trigger shortcodes being inserted as a preview, and I have already tested, if you go to the Text tab of the editor for your page and simply backspace the extra lines before [popup_trigger and after [/popup_trigger] it should render properly on your page. That is only a temporary fix to allow you to use it now while we work out the issue.

Hope that helps.

I think Jan might be being blinded by science here.

Jan… when you write or edit a post in any theme you have your various styling buttons at top left. At top right there are two (and, according to your theme, maybe more) tabs called Visual and Text (and maybe Pagebuilder or something like that).

You are obviously writing in Visual (or Pagebuilder) mode and this mode is interacting badly with the display of the shortcode.

So I suggest you enter the shortcodes in Visual/Pagebuilder mode as normal and then click the Text tab. You’ll see all the same information but in a form that is what is actually read by the browser.

It is in this mode that danieliser is telling you to remove the extra paragraph <p> and </p> marks.

I think what you will see at the moment is something like this:

<p>Some</p>
<p>[popup_trigger]Text[/popup_trigger]</p>
<p>in a line.</p>

but you need something like this:

<p>Some [popup_trigger]Text[/popup_trigger] in a line.</p>

Once it is all tidied up, then update your post/page in that Text mode.

Hope it makes things a bit clearer for you!

@milestone – You are correct, but most of the time even the <p> tags are not in the text tab, your example above is exactly correct and outlines how WP processes the content.

If either of these are in the text tab the output will be the same.

<p>Some</p>
<p>[popup_trigger]Text[/popup_trigger]</p>
<p>in a line.</p>

Some

[popup_trigger]Text[/popup_trigger]

in a line.

Also both can be resolved in roughly the same way.

<p>Some [popup_trigger]Text[/popup_trigger] in a line.</p>

Some [popup_trigger]Text[/popup_trigger] in a line.

Either way you need to remove the separation between Some and [popup_trigger.

Hope that helps.

@danieliser – Yep, absolutely right!

I suspect Jan is using a Pagebuilder type environment which can be real messy in Text mode (and often fails in round-tripping between modes in my opinion).

Hi,

Many thanks for the discussion, tips and trics.

But no builders at all see : https://www.screenmailer.com/v/SGaXglHXUFMhOLg

Bottom line: in a simple wordpress site (twenty ffteen) with all plugins deactvated the popupmaker is not working properly

So what I only want to know is when the isseu is soleved. I don’t want to be bussy manualy with all technical details in text mode.

I am a simple user: not a webengineer.
I need a plugin that works and does what is says.

Regards Jan

Hi There,

I hoped that in the new release teh problem was solved.
But that is what not happend.

I tried al the givven solution but what happend is that when I open a page all the pop ups are again in trouble.

In the situation there ar e40 of 50 popups in a page….al the 50 popups must be reorderd ??? That is the worst situation ?

Please can yoy help me to solve this problem.

I use a clean wordpress with one plugin..

Regards Jan

@stokertje – Unfortunately this is one of those issues that isn’t a simple one line fix. Thus its not gonna happen quickly. It requires a lot of parts to be changed without breaking other things along the way.

Also in the situation of 40-50 popups on one page I would recommend against that entirely. If you must have that then I recommend a solution such as our Remote Content extension which can change content based on what was clicked so that only one popup needs to be loaded.

The solution would have no bearing on popups working, but only the format of the text triggers.

I apologize that the available solution is not as simple as you would like, but neither are the fixes you are asking for. We can’t just rip out everything for one issue which is what would have to happen for an instant fix, that’s just not a great solution when we are talking 50k websites.

You could try the following but it will still require you to manually correct any posts that have been edited and now include the extra space.

Add this to your themes functions.php to disable the button entirely.

remove_action( 'admin_init', array( PUM_Admin_Shortcode_UI::instance(), 'init_editor' ), 20 );

Hope that helps in your case.

Hi,

am i the only one with this problem ?

I have no problem to invest and buy remote content extension if that fix the problem. So when i buy the plugin the problem is solved ?

Evenso; no problems with al the other defined popups ?

regards Jan

@daniel – would another filter plugin to remove the extra line-breaks fix the problem? So the main plugin needn’t be altered?

It’s a WP problem with all inline shortcodes methinks so might have some traction (ie search for shortcode name, find square brackets either side, delete line breaks at this point?).

Really for WP to fix but as a temporary work around…