Disable for Logged-In users / administrators

  • Resolved michelnyx

    (@michelnyx)


    4 years, 8 months ago

    Hello EWWW team!

    I’m using this plugin on my website, great!

    But the lazy load / webp replace feature (with JS) is bricking our website when we edit using our standard theme editor.

    For an example: If we need to edit our main page, we currently need to disable the lazy load / replace or all our visitors with and without webp browser support will see all pages with webp (because this plug-in do it even we’re in editing mode).

    Please add an option on this plugin to disable the lazy / replace feature when anyone is logged in.

    Thanks.

    • This topic was modified 4 years, 8 months ago by michelnyx.
Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author nosilver4u

    (@nosilver4u)

    We can exclude the theme builder directly in our code if you could provide more information on which theme you are using, and what the URLs look like when using the theme-based editor. Otherwise, there are filters you can use to disable either function yourself, but that’s not ideal for compatibility issues like this.

    Thread Starter michelnyx

    (@michelnyx)

    Hello!!

    My theme is Materialis.

    When we enable the JS rewriting, on the main page edit all our images are changed to WebP, the same for Lazy Load.

    It’s bricking our end users (and also our template).

    Best Regards,

    Plugin Author nosilver4u

    (@nosilver4u)

    Right, I understand that and would like to make sure we are excluding your theme editor by default for these front-end functions. To do so, we need to know what theme you are using, and what the editor URL looks like.
    For example, most theme-based editors will add query parameters like so:

    https://example.com/sample-page/?theme-editor=1&other-param=3

    What we are particularly interested in there, would be the portion after the ?:
    ?theme-editor=1&other-param=3

    If you can let us know what that looks like for your theme and/or what theme you are using, we can add it as a core/default exclusion. This will help everyone who uses that theme, both now and in the future!

    Thread Starter michelnyx

    (@michelnyx)

    Hello nosilver.

    The URL in edit mode is:

    https://my-website.com/wp-admin/customize.php?url=https%3A%2F%2Fmy-website.com%2F

    When I do it in other pages, the ‘url’ query parameter changes.

    I’m using the Materialis theme.

    Thanks for advance.

    Plugin Author nosilver4u

    (@nosilver4u)

    That just looks like the stock customizer, and you’re getting JS WebP and Lazy Load running in there?

    Thread Starter michelnyx

    (@michelnyx)

    That just looks like the stock customizer, and you’re getting JS WebP and Lazy Load running in there?

    Yes, I’m getting the JS WebP / Lazy Load running on this page, when I save my customizations with JS/Webp enabled, all webp replaces are globally applied to all our visitors (even no browser support to it).

    Lazy load also is applied (and conflicts with our theme at the end of the day).

    • This reply was modified 4 years, 8 months ago by michelnyx.
    • This reply was modified 4 years, 8 months ago by michelnyx.
    Plugin Author nosilver4u

    (@nosilver4u)

    Confirmed, even with stock Twenty Twenty theme, fix will be in next release!
    Pre-release on Github if you need it: https://docs.ewww.io/article/73-update-from-github

    Thread Starter michelnyx

    (@michelnyx)

    Alright I’ll do a test.

    Thanks for your support.

    Thread Starter michelnyx

    (@michelnyx)

    @nosilver4u thanks, it’s solved on the last update you released.

    Best Regards,

    Michel.

    • This reply was modified 4 years, 7 months ago by michelnyx.
Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Disable for Logged-In users / administrators’ is closed to new replies.