Did not test enough

  • Resolved drtonyb

    (@drtonyb)


    7 years, 1 month ago

    At least one error that screws up the html for most themes. In templates under global, in wrapper-start.php the code for default themes is:

    		echo '<div id="primary" class="content-area"><main id="main" class="site-main" role="main">';

    But in wrapper-end.php the code for default themes is:

    		echo '</div></main>';

    The latter needs to be reversed to be:

    		echo '</main></div>';
Viewing 2 replies - 1 through 2 (of 2 total)
  • Caleb Burks

    (@icaleb)

    Automattic Happiness Engineer

    Thanks for the report. Opened an issue here: https://github.com/woocommerce/woocommerce/issues/18734

    Thread Starter drtonyb

    (@drtonyb)

    Thanks Caleb, just a note on your comment in the issue opened on github that the browser should be able to correct this problem: for me using Firefox, it threw the footer div block outside the site wrapping div, so the footer and its content became full width, and the css styling in the footer became confused so that text defaulted to black, the same colour as the background and ‘disappeared’. Fortunately, I tested on my development system before updating the live site.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Did not test enough’ is closed to new replies.