Deprecated functions in Google Site Kit plugin

  • Resolved diegpl

    (@diegpl)


    2 years, 5 months ago

    Hi, there are two deprecated functions being used in the plugin, which can be bad for the plugins performance. Could you guys, please, fix it in the next version? Tks! ??

    Constant FILTER_SANITIZE_STRING is deprecated

    wp-content/plugins/google-site-kit/includes/Core/Admin/Standalone.php:95
Google\S\C\A\Standalone->is_standalone()
wp-content/plugins/google-site-kit/includes/Core/Admin/Standalone.php:53
Google\S\C\A\Standalone->register()
wp-content/plugins/google-site-kit/includes/Plugin.php:196
Google\S\Plugin->Google\S\{closure}()
wp-includes/class-wp-hook.php:307
do_action('init')
wp-settings.php:598

    filter_input(): Passing null to parameter #4 ($options) of type array|int is deprecated

    wp-content/plugins/google-site-kit/includes/Core/Util/Input.php:64
filter_input()
wp-content/plugins/google-site-kit/includes/Core/Util/Input.php:64
Google\S\C\U\Input->filter()
wp-content/plugins/google-site-kit/includes/Core/Admin/Standalone.php:95
Google\S\C\A\Standalone->is_standalone()
wp-content/plugins/google-site-kit/includes/Core/Admin/Standalone.php:53
Google\S\C\A\Standalone->register()
wp-content/plugins/google-site-kit/includes/Plugin.php:196
Google\S\Plugin->Google\S\{closure}()
wp-includes/class-wp-hook.php:307
do_action('init')
wp-settings.php:598

    Constant FILTER_SANITIZE_STRING is deprecated

    wp-content/plugins/google-site-kit/includes/Core/Authentication/Authentication.php:308
Google\S\C\A\Authentication->Google\S\C\A\{closure}()
wp-includes/class-wp-hook.php:307
do_action('admin_init')
wp-admin/admin.php:175
    • This topic was modified 2 years, 5 months ago by diegpl.
Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter diegpl

    (@diegpl)

    You might want to change:

    $page = $this->context->input()->filter( INPUT_GET, 'page', FILTER_SANITIZE_STRING );

    for

    $page = $this->context->input()->filter( INPUT_GET, 'page', FILTER_UNSAFE_RAW );

    • This reply was modified 2 years, 5 months ago by diegpl.
    Plugin Support Adam Dunnage

    (@adamdunnage)

    Hi @diegpl thanks for flagging this. I will raise this with the team and provide an update once it has been discussed.

    Plugin Support Adam Dunnage

    (@adamdunnage)

    @diegpl Thanks for you patience. It looks like you are likely running PHP 8 on your site is that correct? These are related to PHP 8 and should not affect Site Kit from working for you as you.

    We will certainly look into these to ensure anything that needs addressing will be done so.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Deprecated functions in Google Site Kit plugin’ is closed to new replies.