deprecated function “create_function”

  • tazotodua

    (@tazotodua)


    6 years ago

    we get this messages:

    1) ( ! ) Deprecated: Function create_function() is deprecated in ….wp-content\plugins\archives-calendar-widget\archives-calendar.php on line 69

    View post on imgur.com

    instead, you should use like:

    add_action("blabla...", function(){ } );

    2) Notice: Undefined index: title in \wp-content\plugins\archives-calendar-widget\arw-widget.php on line 20

    3) Warning: count(): Parameter must be an array or an object that implements Countable in wp-content\plugins\archives-calendar-widget\arw-widget.php on line 154

    4) Warning: count(): Parameter must be an array or an object that implements Countable in \wp-content\plugins\archives-calendar-widget\arw-widget.php on line 185

    5) (if chosen “months” instead of “years” in widget) Warning: count(): Parameter must be an array or an object that implements Countable in wp-content\plugins\archives-calendar-widget\arw-widget.php on line 388

    6) if you can, please integrate ARCW Popover plugin. Please dont read full readme where you mention that there exist such addon. I accidentally saw that. So, please just integrate that inside the main plugin.

    7) for ARCW popover addon, i have this suggestion for changes:
    – on line 74th, you should have this code:

    	$cat       = !empty($params['cats']) ? $params['cats'] : '';
	$post_type = !empty($params['posts']) ? $params['posts'] : 'post';

    first thing is that it should check with (!empty) otherwise throws error, when that arcf parameter not defined at all.

    8) also, there is some bug in your plugin. For example, I choose “xyz” custom post type in main plugin, and it shows calendar well, but the popover plugin send the request, which only gets ‘post’ post-types, and not the custom-post which is set for that calendar. I think, from main calendar widget, you should output the javascript variable, which determines what custom post-types are being used, and the popover plugin should use that variable and send request to use that custom-post-types. (at this moment I see that uses $url = $_POST['link'] with from where it tries to get some arguments of arcf parameter, which is incorrect, as our urls are like : example.com/2017/03/ and there are no arcf arguments in url)

    9) also, will be nice to integrate apply_filters as many places as possible, so we can hook into plugin smoothly, like:

            $args  =apply_filters('arcw_arguments_filter', $args);
	$posts_array = get_posts( $args );

    and also in other places.

    10) would be nice if in the bottom of calendar, there was a h2 (or bolded) text, which shows of which category posts are being shown on calendar (when calendar query was made with $cat parameter). If possible, the category chooser under calendar, will be much better!

    shortly, enable wp_debug and test your plugin fully on clean wordpress install, to see all the problems.

    thanks, nice plugin !

    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
    • This topic was modified 6 years ago by tazotodua.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter tazotodua

    (@tazotodua)

    11) one problem is that when we popover on the day, we cant go to the below area (see the example image for date 6). I think it’s better it was a bit right side, so we can mouseover the below cell too, like on the second image:

    View post on imgur.com

    12) I think on many places, you incorrectly use count($var) to check if that variable is set or not. You should replace all such places with !empty($var) i think. for example, when we check “archive filter checkbox”, then we get: Warning: count(): Parameter must be an array or an object that implements Countable \wp-content\plugins\archives-calendar-widget\archives-calendar.php on line 128. There, the $type variable seems set to : “post,my_book”. if that is supposed to be the string, then count( $type ) should be removed (and !empty($type) is better), if it should be an array, then there seems a problem somewhere, as it returns string as i mentioned.

    13) $cats variable seems nowhere declared here: Warning: count(): Parameter must be an array or an object that implements Countable in wp-content\plugins\archives-calendar-widget\arw-widget-settings.php on line 108 .
    i think there should be !empty($cats).

    14) When we check/checkbox in widget for any target category, then calendar output gives:
    Notice: Undefined offset: 0 in wp-content\plugins\archives-calendar-widget\arw-widget.php on line 342

    that happens, because $month_select is being set to empty but you dont have any case in switch loop, where $months array will be set for that case. so $months[0] fires an error in that case. I think, temporary workaround could be to insert case for empty too above current, so it will use current‘s code.

    
		case 'empty':
		case 'current':
    • This reply was modified 6 years ago by tazotodua.
    • This reply was modified 6 years ago by tazotodua.
    • This reply was modified 6 years ago by tazotodua.
    • This reply was modified 6 years ago by tazotodua.
    • This reply was modified 6 years ago by tazotodua.
    • This reply was modified 6 years ago by tazotodua.
    • This reply was modified 6 years ago by tazotodua.
    • This reply was modified 6 years ago by tazotodua.
    • This reply was modified 6 years ago by tazotodua.
    Thread Starter tazotodua

    (@tazotodua)

    15) it will be nice if the plugin had transient_caching, it means that when the same query is made (by different visitors) for exmaple, for 2018-05-21 month, the first query should be cached like this:

    $transient_name = md5( json_encode( $args ) );

// We can retrieve latest cache
$result = get_transient( $transient_name );
if ( $transient_results === false) {
    $result  = WP_query (....) //or get_posts, whatever you use.
    set_transient( $transient_name, $result,  3600 );  // 3600 seconds, that is 60 minutes
}
return $result;
    • This reply was modified 6 years ago by tazotodua.
Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘deprecated function “create_function”’ is closed to new replies.