Deprecated Code

  • Resolved ldigregorio

    (@ldigregorio)


    3 years, 8 months ago

    Hello,

    With all the recent JS/JQuery changes to the WP core, yoast is showing deprecated code:

    /wp-content/plugins/wordpress-seo/js/dist/post-edit-1650.js:1:101578): jQuery.unique is deprecated; use jQuery.uniqueSort

    Can the code be updated before core 5.9 release please? If not, it could potentially break our site. Thank you

    I was on vacation when the ticket was closed by Michale Tina, I didn’t have a chance to reply until I returned. Sorry I wasn’t able to get back to you sooner. Here are the answers to questions requested:
    1. We are using WordPress 5.7.2
    2. Yoast 16.5. At the time I wrote this, I think Yoast 16.6.1 has just come out and we were not yet scheduled to do all our upgrades.

    3. Our multi-site meets all the plugin requirements.

    4. Not sure how you would replicate the issue, as I found it by the jquery migrate plugin made by WordPress/automatic –specifically made to find deprecations so they can be fixed before core 5.9 release. Maybe install their plugin to find the issues with your plugin?

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Support Maybellyne

    (@maybellyne)

    Hello Idigregorio,

    Thanks for following up.

    We recently released Yoast SEO 16.7, does the deprecated code still show if you update to that version of the plugin?

    Thread Starter ldigregorio

    (@ldigregorio)

    Hi Maybellyne,
    Thank you for the reply. We plan to update this week so please give me time to do that before closing the ticket. I will get back to you after the update this week. Thank you

    Thread Starter ldigregorio

    (@ldigregorio)

    Hi Maybellyne,

    Just updated to 16.7 and the original deprecation issue doesn’t appear:

    /wp-content/plugins/wordpress-seo/js/dist/post-edit-1650.js:1:101578): jQuery.unique is deprecated; use jQuery.uniqueSort

    However, after upgrade, this deprecation issue appears. Can this be fixed please?

    /wp-content/plugins/wordpress-seo/js/dist/api-client-1670.js:1:1262): jQuery.isFunction() is deprecated

    Plugin Support Md Mazedul Islam Khan

    (@mazedulislamkhan)

    Thanks for following up with us @ldigregorio. Can you please confirm where exactly do you see the relevant jQuery.isFunction() is deprecated notice? Is there a specific page where we can take a look at to reproduce the notice?

    We look forward to hearing from you.

    Thread Starter ldigregorio

    (@ldigregorio)

    Hello Mazedul,

    Thank you for getting back to me. I don’t think looking at the page is going to help. The jquery migrate helper plugin actually found this issue. This plugin was created by Automatic to find these issues so they can be fixed before the backward compatibility for jquery is stripped from core in WP 5.9. Maybe there would be more mileage from looking at the code where the deprecation occurs. Can the deprecation be fixed? Send updated code so I can test it using the plugin again. Or, please install the plugin and test it there. Thank you

    Plugin Support Md Mazedul Islam Khan

    (@mazedulislamkhan)

    Thanks for your confirmation, @ldigregorio. We could definitely try upgrading from the deprecated part of our code. In this case, we recommend you please submit a proper bug report directly at our GitHub development repository so our development team can look into this further.

    We actively track bug reports on our GitHub development repository rather than in the public forum. In this way, you’d be able to follow the progress of the relevant bug report as well.

    Plugin Support devnihil

    (@devnihil)

    We are going ahead and marking this issue as resolved due to inactivity. If you require any further assistance please create a new issue.

    Thread Starter ldigregorio

    (@ldigregorio)

    FYI…the issue was taken to GITHUB. After GITHUB, it was transferred to an internal queue to be fixed. So the issue is not really resolved, but moved to different lists. It still needs to be fixed before core 5.9

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Deprecated Code’ is closed to new replies.