Debug feedback

  • Resolved Bonaldi

    (@bonaldi)


    5 months, 2 weeks ago

    Hi Marc,

    I’ve translated the plugin completely into French.

    A few points to note:

    Some translation strings do not appear to be translatable (backend)

    • WordPress Login & Registration
      (compatibility/wordpress/ControllerWordpress.class.php, line 18)
    • WooCommerce Login & Registration
      (compatibility/woocommerce/ControllerWoocommerce.class.php, line 19)
    • Hooks: (textdomain?)
      (ui/controller/UI_Dashboard.php, line 1100)
    • Dashboard (submenu)
      (ui/controller/UI_Dashboard.php, line 27)
    • Log Entries (submenu)
      (core/log/Log_WordPress.class.php, line 70)

    UI (frontend)

    • The black reload icon is not visible on dark themes and could be spaced out.
    • The label before the image and math CAPTCHAs calculation is awkward or should be customizable: for example on CF7 it could be defined above by a custom text field, but it seems impossible to remove easily the hard-coded label.
      (core/protection/captcha/CaptchaImageGenerator.class.php, line 222)
      (core/protection/captcha/CaptchaMathGenerator.class.php, line 289)

    Miscellaneous

    • Documentation not up to date, difficult to find customization syntax, as for example for CF7: “placeholder” for placeholders (documentation in English would be welcome).

    Regards.

Viewing 15 replies - 1 through 15 (of 16 total)
  • Plugin Author forge12

    (@forge12)

    Hello @bonaldi

    thank you for your feedback. We already implemented the missing text strings, updated the UI to allow custom labels/placeholders, added a toggle for the reload icon (white/black) and added custom css classes for the captcha to have better options to style it within the frontend.

    We’ve also added a filter to use a custom icon for the reload.

    The update will be released tomorrow if no issues appear.

    May i ask for some details about the “placeholder” you are talking about?

    Best Regards
    Marc

    Thread Starter Bonaldi

    (@bonaldi)

    Hello

    When you built a form in CF7, you was able to add some items like the placeholder here:

    [f12_captcha f12_captcha-101 class:captchaf12 id:captchaf12 captcha:math placeholder"?"]
    Thread Starter Bonaldi

    (@bonaldi)

    I note also an empty div in the wrapper and don’t know how to add a class name:

    <div class="">
    <label> CAPTCHA&nbsp;: <span class="captcha-calculation">5 + 3 = ?</span> <a href="javascript:void(0);" class="cf7 captcha-reload" title="Reload CAPTCHA"><img decoding="async" style="margin-top:5px;" src="https://localhost/wp/wp-content/plugins/captcha-for-contact-form-7/core/assets/reload-icon.png" alt="Reload"></a></label><input class="f12c " data-method="math" captchamethod="math" tabindex="" step="" aria-required="true" aria-invalid="false" placeholder="?" value="" type="text" name="f12_captcha-101" id="c_f8f1c011d71920ddeda5">
    </div>

    I note also a space at the end of the input class name:

    class="f12c "
    Thread Starter Bonaldi

    (@bonaldi)

    Personally, I think it would be wiser to put the reload image under the input.
    When the CF7 form is wrapped with “flex-direction: column”, as it already has a hard-coded 5px margin (core/protection/captcha/CaptchaGenerator.class.php, line 89) at the top and no space at the bottom: so it actually fits the input.

    Or add a margin at the bottom too.

    And add “text-align: center” for image.

    Plugin Author forge12

    (@forge12)

    Hello Bonaldi,
    thanks for your feedback. Version 2.0.4 released just now with the implemented suggestions.

    We will start removing the cf7 placeholders with feature updates and switch to an alternative version which will also work using other forms.

    Please look at the newest version, and please don’t hesitate to tell us your feedback.

    Best Regards,
    Marc

    Thread Starter Bonaldi

    (@bonaldi)

    Hello Marc

    Good job.

    Missing escaping/stripslash in new captcha inputs, I get backslashes before apostrophes.

    Regards

    Plugin Author forge12

    (@forge12)

    Hello @bonaldi,

    Where do you get them?

    Best Regards,
    Marc

    Thread Starter Bonaldi

    (@bonaldi)

    ui/controller/UI_Dashboard.php, lines 471 and 486: in frontend apostrophes ‘ becomes \’

    And after backend registration.

    Thread Starter Bonaldi

    (@bonaldi)

    Hi,

    Inputs are not wide enough and are truncated on some screens.

    Regards.

    Thread Starter Bonaldi

    (@bonaldi)

    Hi Marc,
    Something seems to be wrong with some translations.

    Regards.

    Thread Starter Bonaldi

    (@bonaldi)

    Hi Marc.

    1. Do you plan to fix previous points?
    2. Are you interested in the changes/additions I made to the latest version?
      Like for example an additional template because the current ones break the UI of my sites.
      If so, tell me how I can send you the modified files.

    Regards.

    Plugin Author forge12

    (@forge12)

    Hello @bonaldi,
    yes, we intend to solve the issues in the feature. You are welcome to send your templates to [email protected] using WeTransfer.

    Best Regards,
    Marc

    Thread Starter Bonaldi

    (@bonaldi)

    Done.

    Our template resolve label duplication on template-0 and improve display using flexbox and others.

    Somme others small modifications done in code, you can make a diff with actual version ti see it.

    Regards.

    Thread Starter Bonaldi

    (@bonaldi)

    About template-1, I think it would be great to chose the reload button color with images above, because blue isn’t always adapted to UI.

    Regards.

    Plugin Author forge12

    (@forge12)

    Hello @bonaldi , we’ve added your template to the plugin. We’ve also added new texts and updated the translations.

    Best Regards
    Marc

Viewing 15 replies - 1 through 15 (of 16 total)
  • You must be logged in to reply to this topic.