One reason for failure would be if another rule is matched before yours. You generally want to pass the $after parm in add_rewrite_rule() as “top” to avoid this. Another reason for failure is neglecting to visit the permalinks settings screen after changing rules. Doing so causes the current rules to be flushed.