Cudos and feature requests

#page jumps to the very top, including the (massive and almost screen-filling) theme header img. I really prefer jumping to #main which is the beginning of the page content and thus shows (hopefully) something meaningful.

Did you try out my implementation in live?

Hi Thierry,

Yes, saw your implementation, looks good ??

I’ve found an issue with using page slug as an anchor link. If the page was called, for example “Main” then the anchor id wouldn’t be unique as #main already exists. So … we’d have to use #panel-main (for example).

Kind regards,

Oliver

As a guy with French and German roots, I’d most probably never call a page “main” since the Main is just a river near Frankfurt… ??

But it’s definitively a valid point. So I let it up to you to find an improved solution. I’m actually full of admiration how all these things which your plugin does can be done with css and JavaScript/jQuery without physically patching the php code of the theme template files.

Can’t wait to see the next update with named anchors and the back to top options. I promise to calm down after that and to stop harassing you with further feature requests. But I promise, too, that I’ll do another feed run when it will be tested and validated.

Hi Thierry,

OK, just published this in the latest update. The link uses the same arrow that’s used in the navigation menu to scroll down for theme design consistency. Let me know if it’s all working your end.

To be honest, it only dawned on us recently just how much could be achieved by making use of the default WordPress hooks and the Twenty Seventeen theme hooks. Then just a bit of creative jQuery and boom!

We think it’s really important not to mess with the core of a theme, even with a child theme! Updates are super important and this way they are all applied when installed ??

Always welcome a feed run! ??

Oliver

Technically, everything works as expected. Sorry for the delay in feedback, but I had to recreate the menu links and to rewrite some inline links in the page text.

The idea with the arrow svg is really great and much more beautiful than text and there is no need for translations on multilingual sites.

You will perhaps hate me now, but there are two little points which I don’t find fully satisfying from an esthetic point of view:

First, is it mandatory to add the “panel-” prefix to the anchors? I had hoped for cleaner and thus more beautiful links like /#contact instead of /#panel-contact, not sure if this has an effect on search engines when crawling the site for internal links.

Second, with my php hack, I had also added a back to top link at the end of the principal section of the page (before the section panels start) which makes for sure sense if that main page is relatively long and it gives a better optical consistency. I’d really like to see it added…

But I’m perhaps wrong with my ideas. What do you think?

• This reply was modified 6 years, 4 months ago by Thierry.

OK, so with regards to your first point, the unique ID problem is still something that cannot be ignored … SO … I’ve (hopefully) noted all the IDs that you would get …

            $id_cannot_be = array(
                'page',
                'masthead',
                'site-navigation',
                'top-menu',
                'content',
                'primary',
                'main',
                'secondary',
                'colophon',
                'wpadminbar',
                'wp-toolbar'
            );
            $id_cannot_start_with = array('wp-admin-bar-',
                'adminbar',
                'icon-',
                'menu-item-',
                'post-',
                'panel');
            $id_cannot_end_with = array(
                '-css'
            );

… and I’m just finishing the code to inject “panel-” at the beginning of the ID but only if it matches with one of the rules above. Obviously I’ve got to do this quickly because every time we change it … users are going to have to re-build their menus; as you have discovered.

Your second point will be dealt with when I add the option to add “Back to top” links to pages … it’s coming, don’t worry!

Kind regards,

Oliver

PS – Thanks for the payment!!

That sounds very good. Even if one or two “system slugs” were missing in the above list, these could be added later when user feedback would reveal problems, but further exclusions would only require a minor manual menu rework of the affected link, so the actual rules seem to be an excellent starting point.

I know that my modest payments are far from covering all the time which you actually put into the development and I know that me being finicky can be a pain (sorry for that), but my intention is to make this a still better plugin which would then find favor in the eyes of still more wordpress users to multiply your revenues (hopefully) exponentially. ??

OK, I’ve just pushed an update to cover this. Hope you like ??

And don’t worry, totally appreciate all the constructive criticism and payments!

Kind regards,

Oliver

Update works, links reworked, thank you! Now seeing light at the end of the tunnel ??

Glad it’s working as you like.

Oliver