CSS styling affecting non-Maxichart elements on public site

  • Resolved KZeni

    (@kzeni)


    6 years, 6 months ago

    The file at maxicharts-query-builder-add-on/libs/vendor/components/bootstrap/less/forms.less is currently being called on public pages regardless of whether any Maxichart element is on the page. Also, this file has styling which is changing site-wide elements.

    I don’t think a plugin should have any styles which affect elements at a site-wide scope. I’m thinking this aspect will need to be revised to either only include that file when needed (especially not on the site’s public pages) or, these need to be given selectors which restrict which elements are affected.

    Thanks for the great plugins!

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author maxicharts

    (@maxicharts)

    Hi @kzeni,
    Thanks again for your valuable feedback.
    It seems i cannot migrate to github right now…
    Can i give you commit right on wp.org repo so as you can modify what you want, waiting for a github migration?
    Thanks a lot
    Max

    Thread Starter KZeni

    (@kzeni)

    Oh, I’m not waiting for this. I just haven’t dug into the cause of the problem quite yet. I’ve simply opted to deactivate this particular plugin for now. I’ll share the fix if I happen to come up with one, though.

    Ultimately, it appears to stem from Bootstrap being included in the main maxicharts_querybuilder_add_on.php file.

    This is more or less applying the entire Bootstrap CSS, Framework, etc. (without a scope) to a theme that might not be using Bootstrap and/or doesn’t want to.

    I think this should ideally be removed/replaced while still implementing scoped[!] CSS to still have it display as desired. Maybe create a fork of bootstrap where everything is scoped so you don’t have to recreate all of the styles while still preventing this issue.

    Plugin Author maxicharts

    (@maxicharts)

    @kzeni : understood, but as you asked before for another code change to include in the next releases, i was thinking you were in a hurry.
    Unfortunately, i have no time this month to fix this… sorry!
    In case you need a commit right, just ask.

    Thread Starter KZeni

    (@kzeni)

    Got it! Thanks!

    Hello:

    I have same problem, CSS styling affecting many elements on public site… Have you fixed this problem?

    Plugin Author maxicharts

    (@maxicharts)

    @melissacrokis : Unfortunately not yet… but soon!

    • This reply was modified 6 years, 1 month ago by maxicharts.
    Plugin Author maxicharts

    (@maxicharts)

    Bootstrap have been scoped and the plugin updated to work, please delete / reinstall plugin to confirm it works.
    We’ll be releasing then after.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘CSS styling affecting non-Maxichart elements on public site’ is closed to new replies.