Critical bug: memory_limit reached with 2.2.1

Do you have any taxonomy queries on the front end? List of tags or categories?

We added query filtering for terms, but it seems on your site its triggering an infinite loop of some kind.

Can you test any changes for me on your site?

If so maybe try editing this file:

wp-content/plugins/content-control/classes/Controllers/Frontend/Restrictions/QueryTerms.php

Either comment out the filter on like 81, or try adding this before it:

    if ( ! is_rest() ) {
        return;
    }

Thanks for the quick reply.

I can confirm commenting as this fixes the issue:

 79         public function enable_query_filtering() {
 80 //              add_filter( 'get_terms', [ $this, 'restrict_query_terms' ], 10, 4 );
 81         }

It is likely that there are added taxonomies compared to native WordPress, as we are using WooCommerce, WooCommerce Bookings + Accommodations, and WCFM. That is a marketplace booking website. However I’m unsure how to check existing taxonomies.

Hi, thanks for great plugin.

I can confirm that I also have the same issue as above, commented out the filter and the frontend is back up.

Edit: I have noticed, that on some sites, If I update the plugin, and I get a 500 error, or a terminal error; when I deactivate the plugin and refresh, then reactivate and refresh, the site comes back up normally.

Thanks

• This reply was modified 8 months, 1 week ago by Darryl.R.

@darrylr make sure you’ve updated to the very latest 2.2.1 for your tests, as the two latest and very new 2.2.0 and 2.2.1 show different bugs. Also, server logs would help figuring out what’s behind your specific error 500 (memory_limit, other?)

Yep, all version 2.2.1

@robin-labadie, @darrylr – Since this feature was really introduced as part of the REST API protections, I may just back it off to only run there until we learn more about how these queries are being used in the wild.

My thinking is that we are checking term queries too early in the process, but not sure why that is causing issues other than just not protecting those early queries like posts query handling does.

It indicates there must be some recursive nature to things were not accounting for. Then our code runs recursively as well making things compound.

If anyone can clone to staging and narrow to a specific plugin/theme/block/etc it would be helpful, otherwise look for another update later today to disable that for now.

Hallelujah. Thanks for this all, that just saved my site too. Can we expect an update with patch soon?

@danieliser I can’t provide a safe and isolated stating site easily for this site unfortunately. However I can provide you with the list of used plugins and check anything you want as long as it’s in my power.

@darrylr and @heresthecavalry can you please drop down your active plugin list to help the dev identify patterns of what may cause the issue?

Here is mine :

• Carousel Slider Block for Gutenberg 1.0.10 ?
• Complianz | GDPR/CCPA Cookie Consent 7.0.4 ?
• Connect Matomo 1.0.30 ?
• Contact Form 7 5.9.2 ?
• Easy WP SMTP 2.3.0 ?
• Essential Blocks 4.5.3 ?
• HEIC Support 2.1.1 ?
• Loco Translate 2.6.6 ?
• Product Filters for WooCommerce 1.4.16 ?
• Rank Math SEO 1.0.214 ?
• TranslatePress – Developer 1.3.8 ?
• TranslatePress – Multilingual 2.7.3 ?
• Under Construction & Maintenance Mode 1.5.1 ?
• User Switching 1.7.3 ?
• Velvet Blues Update URLs 3.2.10 ?
• WCFM – WooCommerce Frontend Manager 6.7.9 ?
• WCFM – WooCommerce Frontend Manager – Ultimate 6.7.5 ?
• WCFM – WooCommerce Multivendor Marketplace 3.6.7 ?
• WCFM – WooCommerce Multivendor Membership 2.11.3 ?
• WP Crontrol 1.16.1 ?
• WooCommerce 8.6.1 ?
• WooCommerce Accommodation Bookings 1.2.5 ?
• WooCommerce Bookings 2.0.9 ?

Just started coming across this issue as well, had to deactivate the plugin for the time being.

v2.2.2 has this filter disabled outside the rest API. Would love some confirmation that both the issue is gone, and that the rest API is working correctly.

Marking this resolved for now and outside of that it should be good now. I’m gonna have to dig into the plugin lists above and see if I can find the culprit. Once I duplicate it reliably we can nail it down.

That said anybody willing to hunt it down with us can grab one of our free demo sites, duplicate the issue and let us know what steps you took. If you let us know right away and keep the site active we can prevent it from auto deleting and use it to confirm the bug is fixed later.

2.2.2 broke it. Commenting out the line fixed it again.

@robin-labadie – these are the only plugins I have in common with your installation.

Contact Form 7 – 5.9.2
WP Crontrol – 1.16.1
WooCommerce – 8.6.1

Thanks @tbob21 for warning, I know I shouldn’t update yet then.

Thanks @darrylr, Might be related to WooCommerce or WPControl, the two only scripts I can think about that may impact taxonomy.

Hope this helps @danieliser. I’m no PHP dev, just a sysadmin and project manager for WP (so power user++ but still not a dev) so my help is limited on this one, it’s definitely an issue more targeted to the dev that knows his plugin better than anyone.

• This reply was modified 8 months, 1 week ago by Robin Labadie.
• This reply was modified 8 months, 1 week ago by Robin Labadie.

Hi the update broke mine again as well but I commented out the line and it’s ok.
Sorry couldn’t get back with more info last night.
My issue was slightly different I think.
The sites I have with the issue are property rentals sites with custom property posts incorporating a whole bunch of stuff. It’s built with Elementor and a whole slew of Crocoblock plugins. Because of a particular requirement of the client, it also has a separate, different booking calendar. The bug prevented several things from loading but only on the Elementor property template. These included:
– The booking calendar (WP Booking Systems)
– The gallery which is drawn from a dynamic field (jetEngine)
– The Google map which uses a Jet/Croco map widget and draws coordinates data dynamically from a JetEngine custom field.
– Jet Reviews – both an admin-only form where the client adds star ratings (it is not restricted by Content Control, it uses Elementor Dynamic Visibility to hide this form and a couple of other elements that are only for admin use. You might like to note that Content Control is not used on in this template or the page, at all. It is used for a completely separate set of functions for a controlled area accessible only to some clients and a set of pages which the staff use. None of this stuff has any presence on the public frontend..
– The resulting star ratings for the public view. The star ratings appeared fine on the listings elsewhere.

All the issues occurred with the property posts that display through the property template. the rest of the public site was fine. All of these features were still visible and active, showing no errors, inside the template editor, it was just the frontend.

I also have a category order plugin Category Order and Taxonomy Terms Order which is used to manage the order of a number of custom taxonomy terms so that they appear in the right order eg in Filter Selection fields.

There is no woocommerce on the site at all.

I’m insanely busy at the moment but if you want a look inside of one of the sites I could arrange access or do a zoom with you. There are two sites, almost but not quite the same. These two sites which are about 4 years old, have a much higher number of functional plugins than typical at the moment (will be rebuilding fairly soon) because some of the client’s quite complex business requirements went beyond what the initial Elementor/Jet Plugins stack was able to provide at the time. I don’t know if that is more, or less, helpful to you.

The issue in my case is only with Woocommerce pages. After commenting that line out the issue is gone.

It’s using Gutenberg and CPT for content.

There are several other plugins but nothing that should affect taxonomy