Created windows-compatible version

  • Greetings. I was having major issues with this plugin not working on my local dev server (on Windows) even though it worked fine on my prod server (Linux). I tweaked a few things to fix the paths on Windows and it seems to work fine on both platforms now. I created a pull request on github, but since the main plugin page on github is just a mirror of the WordPress plugins svn repository I’m not sure if you’ll get the pull request. You can see the changes here:
    https://github.com/minorgod/adaptive-images/tree/windows-path-fix-for-v0.6.3
    Please feel free to incorporate them into the official version.

    The page I need help with: [log in to see the link]

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Takis Bouyouris

    (@nevma)

    Hello, my friend,

    Thank you for taking the time to make the pull request! Indeed, the plugin is maintained in Subversion and we were not aware of your request up to now.

    I will try to test and incorporate your pull request as soon as possible.

    Thank you for contributing!

    Cheers,
    Takis

    Thread Starter minorgod

    (@minorgod)

    Thanks for incorporating my fixes, but it looks like you only incorporated some of them and now it seems to have broken the plugin for me. Please check the changes in these files as well:

    adaptive-images-actions.php
    adaptive-images-script.php

    Plugin Author Takis Bouyouris

    (@nevma)

    So sorry about that! I will look into it right away.

    Thread Starter minorgod

    (@minorgod)

    Sorry, I withdraw my previous statement. It worked fine on my windows dev machine, but then I deployed it on our linux prod server and it started delivering blank images, so please don’t merge my code yet. Strangely, your latest version works fine on the linux machine, but not on my windows machine. I’ll let you know if I get it sorted out.

    Plugin Author Takis Bouyouris

    (@nevma)

    Okay, then, my friend, I will wait for your updates!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Created windows-compatible version’ is closed to new replies.