Couple of Issues

  • Resolved Oliver Campion

    (@domainsupport)


    2 months, 2 weeks ago

    Hi,

    Nice plugin and seems to work well!

    Just a couple of things we’ve noticed …

    1. It’s not clear that the targeting CSS class has to include the dot (so .example-class rather than just example-class). Can you make it so that if the dot is omitted that you automatically add it or vice versa? Because classes in Block Settings by default don’t have dots I would probably choose not to have them in your setting to conform to that precedent.
    2. If there’s a Gallery Block below the popup button then the gallery images show above the popup. We have resolved this issue with the following CSS …
    .wp-block-makeiteasy-popup {
    z-index: 1;
    }

    Oliver

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Lovro Hrust

    (@lovor)

    Hi Oliver,
    I appreciate your feedback, I was wondering if people are having problems using this plugin and leave without leaving any comment. I am glad it works for you.

    Regarding targeting element which opens popup, the text says “CSS selector”, which means any css selector. In contrast to that, in block advanced settings you define classes.

    I did it on purpose so, in order to use more complex selectors, you can use the same syntax you use in css:

    • targeting id of element: #some-id
    • targeting element with class class-child which is descendant of element with class class-parent: .class-parent .class-child
    • targeting second element inside div element: div :nth-child(2)
    • targeting img element which immediately follows h2 element and both are direct children of element with class card: .class > h2 + img

    You get the idea. So a word without dot in front is assumed to be a html tag, and class has to have dot in front. Instead of changing that functionality to target only classes, I think it’s better that I explain how to construct selectors and where to find help for this.

    For the second part, can you tell which layout type and modality did you use for popup showing before gallery? Is there somewhere example of that I can see (even if it is fixed with css you mentioned)?

    Plugin Author Lovro Hrust

    (@lovor)

    I found that I already explained selectors in FAQ section of readme. I will consider to explain that in plugin in wp admin itself.

    Thread Starter Oliver Campion

    (@domainsupport)

    Ah, selectors! My mistake. This is a more powerful field than I had previously realised. Sorry.

    With regards to the z-index issue, it’s a floating popup. If you add a standard Gallery Block after the popup block you’ll see the issue when it pops up hidden behind the images in the gallery. I’ve tested on Twenty Seventeen and Twenty Twenty-Four.

    Apologies but the site in question is not yet public.

    Thanks.

    Plugin Author Lovro Hrust

    (@lovor)

    I noticed this was left marked as unresolved. I added z-index on popup parent element, so hopefully second issue is also settled.

    Thread Starter Oliver Campion

    (@domainsupport)

    Great news. Thank you.

Viewing 5 replies - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.