Count() warning in edd.php

  • Resolved John Parker

    (@jpwebcast)


    6 years, 1 month ago

    Broadcast version: 43

    Hi Edward,

    We are getting a count() warning generated in our production logs from /threewp-broadcast/src/sdk/wordpress/updater/edd.php:313

    Currently is:
    if ( $workaround && count( $this->edd_get_ssl_workaround_urls() > 0 ) )

    Changed to:
    if ( $workaround && count( $this->edd_get_ssl_workaround_urls() ) > 0 )

    The warning message was filling up our logs as we have a health check program that hits the root of our site every minute. Once we made the above change on our production servers, the warning went away. However, every time we deploy we have to make the change again. Can you put this in the next plugin update?

    Thanks,
    John

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author edward_plainview

    (@edward_plainview)

    In 43.10, the line should be

    if ( $workaround && ( count( $this->edd_get_ssl_workaround_urls() ) > 0 ) )

    What version of 43, more exactly? 43.0?

    Thread Starter John Parker

    (@jpwebcast)

    yes, version 43.0

    Thanks

    Plugin Author edward_plainview

    (@edward_plainview)

    Go ahead and upgrade and you won’t see those warning anymore. Marking as resolved.

    Out of curiousity, is there any reason y’all haven’t updated to the latest version available?

    Thread Starter John Parker

    (@jpwebcast)

    Thanks Edward,

    That should resolve the problem.

    The reason we hadn’t updated to the latest version is because we only tend to update a plugin if there is a specific feature or bugfix that we need. Plus we go through time-intensive testing of plugin updates to make sure it won’t break anything… we usually update one plugin a month.

    This will be the second update to the Broadcast plugin this year.

    Cheers,
    John

    Plugin Author edward_plainview

    (@edward_plainview)

    A logical approach. I send out updates as cautiously as you guys update. Almost. ??

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Count() warning in edd.php’ is closed to new replies.