Could you possibly enable Sender override?

Hi,

Thank you for notifying us!

We will be change this in our next version.

Thanks & Regards

Support Team
Tech Banker

Plugin says it was update a week ago, but doesn’t have the above fix. I can manually patch, but just point out that I guess it didn’t make the next version you mentioned 3 months ago.

Hi,

Thank you for contacting us!

We have released the Latest Edition in which this issue have been addressed.

Kindly Update with the Latest Edition 1.38

If you still face any problem then let us know.

Thanks & Regards

Support Team
Tech Banker

Funny, I just confirmed the change and started updating sites about 10 minutes before this came in. Thanks.

I see you rolled back the changes due to the default wordpress email overriding when it shouldn’t
Example:
WordPress <[email protected]>

You could just account for always replacing the default wordpress email with the user preferred email with the below modified version of the code. If there’s wordpress variables for this that may work better but I didn’t look for that.

if(!is_string($phpmailer->FromName) || $phpmailer->FromName == '' || $phpmailer->FromName == 'WordPress')
{
	$phpmailer->FromName = stripslashes(htmlspecialchars_decode($data->from_name, ENT_QUOTES));
}
	if(!is_string($phpmailer->From) || $phpmailer->From == '' || strpos($phpmailer->From, 'wordpress@') !== FALSE)
{
	$phpmailer->From = $data->from_email;
}
	$phpmailer->Sender = $data->return_path == 0 ? $data->return_email : $phpmailer->From;

Tech-Banker, any thoughts on my revised code?

It’s working fine for me, since it’s essential that plugins like Gravity Forms and ContactForm7 be able to set their own From Name and Email while allowing your plugin to set the From for the generic [email protected] type emails.

Perhaps creating a checkbox in your settings to Enable Sender Override would be the safest option so user can choose how it works now or the more flexible Override option.

Hi @endymion00,

Thank you for your Concern

We will implement this feature very soon in our future releases.

Thanks & Regards

Support Team
Tech Banker

Any update on reintegrating this code in some fashion?

I’ve been manually adding my revised code into each version and it appears to work fine. Maybe just needs a checkbox to allow for some control on activating it as I previously mentioned. Default it to not-checked and it will be the same as prior configs so as to not potentially cause an issue like last time, which was with the original code from the OP before I revised it slightly to account for the problem people described.

I have sites that have multiple forms that send from different senders and without the code revision the plugin doesn’t allow for it. Other mail plugins out there have been crap so this feature would pretty much make it perfect.

Hi,

We will release the new version very soon with the changes requested.

Thanks & Regards

Support Team
Tech Banker

Hi,

Thank you for contacting us!

We have released the Latest Edition in which your problem has been sorted out.

Kindly Update with the Latest Edition 1.42

If you still face any problem then let us know.

Thanks & Regards

Support Team
Tech Banker

Actually the latest version (1.42) doesn’t cover things fully. It only allows the From Name to be flexible and reverts to sending from “WordPress” for wordpress’s default emails.

What the code change above that I’ve been using does (minus having the checkbox) is:

? Allows the default [email protected] emails to be replaced with the From Name and From Email as defined in the WP Mail Bank Settings so you can set your own default.

? When another From exists it will override the set default and use the different From Name and From Email. Currently the plugin is not allowing the From Email to change.

This situation comes up when you use a Form such as Contact Form 7, Gravity Forms, etc. When those forms are used to send from a different email such as for different company departments it needs to allow both the From Name and From Email to be changed. This issue can also come up with emails sent from e-commerce plugins and any other email notification systems that you want to allow different From Name and Emails on.

Note that this doesn’t require separate authentication information as long as one is using and SMTP username that is authorized to send mail for the company’s addresses. This is why it’s a more advanced feature enabled with a checkbox.

So, it would be better having the checkbox option be more like: “Allow From Name and From Email to be set outside of WP Mail Bank by other plugins (ex. contact forms and other notification plugins)”.

This way one can still set the default From Name and From Email in WP Mail Bank to change away from the WordPress default, but still allow for one to create Forms, etc. that change that From Name and From Email as needed.

Hmmm, I had a version 1.42 that Just had the From Name checkbox and not the From Email checkbox, but I noticed both are now mentioned in the changelog so I deleted the plugin and re-installed it and now see 2 checkboxes.

I believe my notes about allowing the default From Name and From Emails to be changed by WP Mail Bank while allowing others still applies.

Also, it appears that the “Set the return-path to match the From Email” doesn’t take into account the new settings so the return-path doesn’t actually match from contact forms. It worked with the manual patch from above.

Any further thoughts on this? I’ve stuck with a modified version of 1.41 one due to the broken Return-path issue and the ability to allow the From Name and Email to apply, overriding the [email protected], when another Name and Email are not supplied elsewhere as described earlier.

Maybe I should again search for an alternate plugin for SMTP mailing.