• Resolved madmax4ever

    (@madmax4ever)


    Hello,

    This is not a bug, just a small request and a way to share my discovery.

    I had trouble settings Facebook login on my site using some plugin.
    In fact, after FB authentication, my page was loaded and a thickbox window should pop. But it did not. I found that thickbox.css needed deshicons for its close button and that I disabling dashicons in Site-Wide Common Unloads section, also unloaded thickbox.css though (as dependant of it). So it couldn’t work. Crystal clear.

    But as thickbox is quite a used function (Am i wrong?), pointing this relation between the two in your precious advices in your plugin (in Disable Dashicons if Toolbar is hidden (Site-Wide) option) could warn others.

    Anyway, thanks to your plugin, dashicons remain unloaded on my website everywhere but in this page. (Note that, as a consequence of the dependancy, I could achieve this only by loading thickbox.css myself, using another handler than the WP one).

    Thanks again for your great work!

Viewing 1 replies (of 1 total)
  • Plugin Author Gabe Livan

    (@gabelivan)

    @madmax4ever thank you for pointing this out! I got a few complaints related to Thickbox and Dashicons. I’ll think of something that would be good for everyone. It would be either checking if there are any dependants and DO NOT unload Dashicons OR just put a notice about it and the admin could leave this option disabled and handle this on a page level such as unloading Dashicons on specific pages.

Viewing 1 replies (of 1 total)
  • The topic ‘Could you add an advice about thickbox on “Disable Dashicons […]”?’ is closed to new replies.