Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter DivaVocals

    (@divavocals)

    Justin Fletcher wrote:

    DivaVocals thanks for the js warning I found the issue and it’s one scenario that was missed during testing. where you have the ‘tabby responsive tabs’ plugin active but not set in the help notes settings for use with the contents page. I’ve just published version 1.6 along with a fix for this. Its not the same issue though as this post. Let me know if its ok for you now.

    To answer your question Justin.. Just downloaded and installed the update to this plugin.. No change.. still the same behavior..

    Thread Starter DivaVocals

    (@divavocals)

    More information..

    in this file “role-based-help-notes/role-based-help-notes.php”, there is a call to the “role-based-help-notes/js/contents-page-scroll-to-section.js” file..

    /**
         * Loads java script.
         *
         * @return void
         */
        public function scripts() {
    
            if ( ! get_option( 'rbhn_tabbed_contents_page' ) || // settings have tabby tabs not set for use with the contents page
                ( ! is_plugin_active( 'tabby-responsive-tabs/tabby-responsive-tabs.php' ) && // and neither plugin must be active
                ! is_plugin_active_for_network( 'tabby-responsive-tabs/tabby-responsive-tabs.php' ) )
                ) {
    
                //Add java content to the Contents Page to scroll elegantly to the reference help note. 
    
                $contents_page_id = get_option( 'rbhn_contents_page' ) ;
    
                if ( is_page( $contents_page_id ) ) {
                    wp_enqueue_script(
                            'contentspage',
                            plugins_url( 'js/contents-page-scroll-to-section.js' , __FILE__ ),
                            array('jquery'),
                            $this->plugin_get_version( ),
                            true);
                }
            }
    
        }

    in the “role-based-help-notes/js/contents-page-scroll-to-section.js” file this line is the source of issues I am having
    scrollTop: $(post_type).offset().top -50

    This is the error I see in the site inspector tool:

    Uncaught TypeError: Cannot read property ‘top’ of undefined
    goto_section @ contents-page-scroll-to-section.js?ver=1.6:19
    (anonymous function) @ contents-page-scroll-to-section.js?ver=1.6:27
    m.Callbacks.j @ jquery.js?ver=1.11.3:2
    m.Callbacks.k.fireWith @ jquery.js?ver=1.11.3:2
    m.extend.ready @ jquery.js?ver=1.11.3:2J @ jquery.js?ver=1.11.3:2

    Plugin Author Justin Fletcher

    (@justinticktock)

    Thanks I’ve added a condition around the goto_section call since when calling the Help Notes Contents page directly without post_type information the call (as you pointed out) relates to missing elements and so java dies. The Fix will be in version 1.6.1 coming. Let me know how you get on when you’ve updated.

    Thread Starter DivaVocals

    (@divavocals)

    thanks Justin.. will look out for the updated version.. I LOVE this plugin, and I’ve been lost with it disabled.. ??

    Plugin Author Justin Fletcher

    (@justinticktock)

    Hopefully your all Ok now I’ll mark as resolved, come back to me if you still have issues.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Conflict with WP-Client’ is closed to new replies.