Conflict with Google Maps Builder

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author CodeFish

    (@codewahoo)

    Hi Kevin,

    you can dequeue Google Maps using googlemaps-api handle.

    Adding the following code to your theme should do the job:

    function admin_scripts() {
  wp_dequeue_script('googlemaps-api');
  wp_deregister_script('googlemaps-api');
}
add_action('admin_enqueue_scripts','admin_scripts',100);

    You might add extra conditions to dequeue the script at certain pages only like Google Maps Builder pages.

    Making hard enqueue like ACF Google Map Extended currently does is not the most elegant way, but the dynamic loading through google.load (which is in place btw) had several compatibility issues.

    Btw, Google Maps Builder implements the code, which prevents adding Google Maps twice. But somehow it doesn’t do the job.

    Thread Starter Kevin Hoffman

    (@kevinwhoffman)

    Thanks for the response. I added this to functions.php but I still can’t see the map on the Google Maps Builder post creation page. These are the errors in console that might be relevant:

    You have included the Google Maps API multiple times on this page. This may cause unexpected errors.
    Uncaught TypeError: Cannot read property ‘maps’ of undefined
    Uncaught TypeError: _.oa is not a function

    Those errors do not appear when your plugin is deactivated.

    I’m also aware that GMB is supposed to prevent this but something’s not working properly.

    Plugin Author CodeFish

    (@codewahoo)

    Kevin,
    could you run a search for ‘maps.googleapis’ in the source of the problematic page and post all the lines, where it appears together with one preceding line? Posting your page’s HTML source code somewhere would also work.
    It looks like there is some other plugin/code referring to Google Maps API, despite the fact you state that no errors appear, if you deactivate ACF Google Map Extended plugin.

    Thanks.

    Thread Starter Kevin Hoffman

    (@kevinwhoffman)

    Here you go. These are the two mentions of ‘maps.googleapis’ with one line before and after. Note that both of these scripts remain even when I include the above function to deregister.

    In <head>:

    <script type='text/javascript' src='https://test.dev/app/plugins/google-maps-builder-pro/assets/js/plugins/gmb-magnific.js?ver=2.0.2'></script>
<script type='text/javascript' src='https://maps.googleapis.com/maps/api/js?v=3.exp&sensor=false&libraries=places%2Cdrawing&key=AIzaSyAolFStdDTXMc6Qqk6-Elwl8-1NvMpM-wg&ver=4.4.1'></script>
<script type='text/javascript' src='https://test.dev/app/plugins/google-maps-builder-pro/includes/libraries/map-icons/js/map-icons.js?ver=4.4.1'></script>

    In footer:

    <script type='text/javascript' src='https://test.dev/wp/wp-includes/js/jquery/ui/datepicker.min.js?ver=1.11.4'></script>
<script type='text/javascript' src='//maps.googleapis.com/maps/api/js?v=3&sensor=false&libraries=places&ver=3'></script>
<script type='text/javascript' src='https://test.dev/app/plugins/advanced-custom-fields-google-map-extended/js/input.js?ver=1.0.1'></script>

    As expected, the footer script goes away when I deactivate ACF Google Map Extended.

    Plugin Author CodeFish

    (@codewahoo)

    Kevin,
    If the page contains a reference to ACF Google Map Extended’s JavaScript file (input.js) and a reference tao Google Maps API JS, then I must say that dequeue is not triggered. Please add some debug code into the admin_scripts function I provided to check, if the routine ever gets there. The expected behavior is that no ACF Google Map Extended’s JavaScript is output at all.
    Could you also provide the following information:

    1. WP version
    2. ACF version
    3. Did you add ACF GME’s field to GMB’s posts?

    Typically, there should be no script outputs from ACF Google Map Extended at pages that don’t use it – ACF controls that.

    Thread Starter Kevin Hoffman

    (@kevinwhoffman)

    I confirmed that the dequeue function is indeed running by using an error_log statement, but the plugin’s JS still remains in the source.

    1. WP 4.4.1
    2. ACF Pro 3.7.1
    3. There are no ACF fields associated with the GMB post.

    Plugin Author CodeFish

    (@codewahoo)

    Kevin,
    my best guess is that your outdated ACF Pro version is causing the issues.
    I tested within my installation of WP 4.4.1 with ACF 4.4.5 and ACF Pro 5.3.2.2 and dequeue likes it should be – no sign of ACF Google Map Extended in the HTML code. Moreover, there is no sign of it even without dequeue, as long as you don’t add the field to the GMB post, as ACF is smart enough not load not used fields.
    That’s the maximum support I can provide you as it goes way beyond just plugin’s functionality and I feel like shooting with my eyes closed with the data I have.
    Nevertheless, you gave me a good idea, that there might be problems and
    I will add a JS variable allowing to alter Google Maps API loading by the plugin. Look forward for the next release.

    Thread Starter Kevin Hoffman

    (@kevinwhoffman)

    I gave you the version of the plugin above it… very sorry about that. I’m also on ACF Pro 5.3.2.2. Thanks for looking into it. I will keep digging and report back if I find anything.

    Plugin Author CodeFish

    (@codewahoo)

    Kevin,

    the version of ACF Pro that you provided was 3.7.1, whereas in your latest message you claimed to have 5.3.2.2 (latest known).

    In any case, I still don’t see the reason for the dequeue not working. It is really strange and I would appreciate, if you post eventually the resolution steps here.

    Thanks.

    Thread Starter Kevin Hoffman

    (@kevinwhoffman)

    I’ve figured it out. First let me clarify I’ve been using ACF Pro 5.3.2.2 the whole time. I mistakenly told you the wrong version in a previous post. Sorry about that.

    The way I got the script to dequeue was by hooking into acf/input/admin_enqueue_scripts instead of admin_enqueue_scripts. I tried this when I discovered your plugin’s scripts were being enqueued inside the function input_admin_enqueue_scripts() which hooks into acf/input/admin_enqueue_scripts in the ACF Pro plugin.

    I’m not sure but I think acf/input/admin_enqueue_scripts fires after admin_enqueue_scripts which means the original function you provided was being executed too early, so we were attempting to dequeue it before it had been enqueued in the first place.

    One other note is that I’ve targeted the input script handle acf-input-google-map-extended instead of google-maps-api because the former depends on the latter and this prevents a broken dependency notice in Query Monitor.

    Finally, the conditional ensures your script only gets dequeued on the post_type of google_maps which is used by Google Maps Builder Pro.

    Here is the full solution:

    /**
 * Prevent conflict between ACF: Google Map Extended and Google Maps Builder
 * Pro by dequeuing script only if current post_type is google_maps (the
 * post_type used by Google Maps Builder Pro)
 */
function prevent_google_maps_api_conflict() {
  if ( get_current_screen()->post_type == 'google_maps' ) {
    wp_dequeue_script( 'acf-input-google-map-extended' );
    wp_deregister_script( 'acf-input-google-map-extended' );
  }
}
add_action( 'acf/input/admin_enqueue_scripts', 'prevent_google_maps_api_conflict', 100 );
    Plugin Author CodeFish

    (@codewahoo)

    I’m glad that you managed to solve the issue.

    I’m still clued why there was a reference to ACF Google Map Extended’s scripts at GMB pages even though those pages didn’t include any map field.

    Anyway, thanks for sharing the working solution. I hope this will be helpful for other people having similar conflicts.

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘Conflict with Google Maps Builder’ is closed to new replies.

Tags