Conflict with FileBird (losing folder assoc)

hey @ellmanncreative,

Sure thing – I will download FileBird and test it with FooGallery PRO and then get them working together with no conflicts.

I will let you know what I find

Hey. So, my boss made a judgement call and purchased a different gallery plugin for our use. As such, we won’t be purchasing your gallery right now.

This is a heads-up so that you don’t unnecessarily waste time you could be spending elsewhere.

I hope you didn’t sink too much time into this (though you may still wish to make your gallery compatible with FileBird), and apologise for the change of plans.

Between you and me, your plugin looks and feels better, but the decision has been made.

totally understand – we will stil make sure the 2 plugins are compatible. Thanks for your support ??

Hey, did you get that done by any chance? The plugin we were using was pulled from www.remarpro.com and there’s slight panic going around. ;]

Okay, stuff went down and I managed to get the purchase in (user ID: 1547467, site ID: 2888449). But now I really need that Filebird conflict fixed, please.

Also, who do I ask if I need to correct the invoice and the billing amount? I failed to put the VAT ID in before submitting, things’re a little hectic (expected to deliver website in about a week, still not done w/ the damn galleries!).

@ellmanncreative

I downloaded Filebird and investigated this issue. I managed to locate the problem down to the file includes/class-filebird-topbar.php – the description in this file is “Show media category filter on top bar” which means it should add functionality to the filter bar within the media library/media modal.

Filebird hooks into the WP core action “wp_ajax_save-attachment-compat” and then attempts to save info for the attachment taxonomies from lines 289-302:

        foreach (get_attachment_taxonomies($post) as $taxonomy) {
            //print_r($taxonomy);die;
            //=> folder
            if (isset($attachment_data[$taxonomy])) {

                wp_set_object_terms($id, array_map('trim', preg_split('/,+/', $attachment_data[$taxonomy])), $taxonomy, false);
            } else if (isset($_REQUEST['tax_input']) && isset($_REQUEST['tax_input'][$taxonomy])) {

                //add attachment into foder-term
                wp_set_object_terms($id, $_REQUEST['tax_input'][$taxonomy], $taxonomy, false);
            } else {
                //remove all folder-terms out of attachment
                wp_set_object_terms($id, '', $taxonomy, false);
            }

        }

The line of code that is the issue is line 301:

wp_set_object_terms($id, '', $taxonomy, false);

Which clears all the taxonomy term data from the attachment if no data is found for the attachment, for the taxonomy. They are looking for very specific data and if it does not exist in their format then they clear all terms. I think this logic is wrong and is a bug in their code.

This code also clears all FooGallery media tags and media categories when a thumb is clicked, and I assume will do the same for any attachment taxonomy that any other plugin registers.

@ninjateam – please check this out and fix the bug which clears all taxonomy terms when there is no data in the format you expect. Thanks

Thank you. We have forwarded your findings to Ninja Team directly (via the pro support ticket system). We’ll let you know how the situation develops. Thank you for taking the time to look into the issue.

Also, who do I contact to fix the VAT ID mixup and get a refund on the tax?

… still, now that I re-read everything you’ve written – why would it break their own plugin? The data that is being cleared is Filebird’s data (folder association).

Does this happen because FooGallery attaches some of its own data, and Filebird then removes all of it because it fails to understand some of it?

@ellmanncreative please contact our support via https://fooplugins.com/support to correct the Vat issue.

FooGallery adds it’s own attachment taxonomies, so I guess there is a conflict when there are other attachment taxonomies, added by other plugins.

But again, looking at their code, it does not make sense what they are doingin that action. I cannot figure out what their code is doing and what they need it for their plugin to function.

Hey. I just wanted to update you that Ninja Team has acknowledged the issue and they’re looking into it. We just prompted them for an update on the case.

hey @ellmanncreative – ye the Ninja Team contacted us for a copy of the PRO plugin so they could debug the problem

Ninja Team has provided us with a version they claim fixes the issue.

Initial testing shows that the issue does indeed seem fixed. As such, we’ve enabled the PRO version of your plugin.

Here’s hoping.

• This reply was modified 5 years, 2 months ago by ellmann creative.

Hi @ellmanncreative,

We haven’t heard back from you so I’m going to assume your issue is resolved. Please do open up a new support request if there’s anything else we can help with.

Thanks in advance,

Phill

Yes, it would seem that the issue that we’ve had between FileBird and FooGallery is now resolved.

Your gallery is working great, by the way! It’s exactly what we required, it fits our needs perfectly… I got to say an “I told you so!” ??

Thank you for your support!