Compatability with PHP 7.x

  • Resolved Chuckie

    (@ajtruckle)


    3 years, 2 months ago

    Hi !

    I ran your plugin through a PHP scanner for compatibility with PHP 7.3 and it listed a few things:

    === Stop User Enumeration ===
    File: plugins/stop-user-enumeration/includes/vendor/freemius/wordpress-sdk/includes/sdk/FreemiusWordPress.php
    Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter “$pUrl” was used, and possibly changed (by reference), on line 307.

    File: plugins/stop-user-enumeration/includes/vendor/freemius/wordpress-sdk/includes/class-freemius.php
    Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter “$tag” was used, and possibly changed (by reference), on line 18865.
    Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter “$tag” was used, and possibly changed (by reference), on line 19022.

    File: plugins/stop-user-enumeration/includes/vendor/freemius/wordpress-sdk/includes/class-fs-logger.php
    Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter “$id” was used, and possibly changed (by reference), on line 41.

    File: plugins/stop-user-enumeration/includes/vendor/freemius/wordpress-sdk/config.php
    File has mixed line endings; this may cause incorrect results

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Alan Fuller

    (@alanfuller)

    I’ll raise your concerns this with the Freemius library.

    Thread Starter Chuckie

    (@ajtruckle)

    Thank you.

    Plugin Author Alan Fuller

    (@alanfuller)

    The response is

    File: plugins/stop-user-enumeration/includes/vendor/freemius/wordpress-sdk/config.php
File has mixed line endings; this may cause incorrect results</blockquote>

    This warning will be addressed, but currently results are correct.

    The other warning from your checker e.g.

    Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter “$id” was used, and possibly changed (by reference), on line 41.

    Are not applicable, as the parameters are not changed.

    Thank you for taking the time to run your tool.

    Thread Starter Chuckie

    (@ajtruckle)

    Thanks. I see that freemius library raising warnings in a lot of plugins so it will be good that that library resolves some issues.

    Plugin Author Alan Fuller

    (@alanfuller)

    They are not ‘real’ issues as such. Freemius is now used in a great many plugins and is functionally sound as far as I’m aware. The warnings raised by your ‘compatibility’ tool for instance don’t appear in server logs, if they did there would be lots of developers shouting at Freemius, as most developers work with warnings & notices displayed not just logged.

    • This reply was modified 3 years, 1 month ago by Alan Fuller.
    • This reply was modified 3 years, 1 month ago by Alan Fuller.
    Plugin Author Alan Fuller

    (@alanfuller)

    Just FYI this plugin no longer uses the Freemius library so no longer an issue.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Compatability with PHP 7.x’ is closed to new replies.

Tags