Comments Form Submit Button HTML – Change Request

  • All of the html for the comments form is moddable apart from the submit button. This annoys me greatly, as the submit-button is contained by a <p> tag? It’s not a paragraph, it’s a button. This means it gets the wrong styles.

    I’ve found that the <p> tag appears because it’s hard coded on line 1577 of this file here.

    Please could you make it so that the containing <p> is a default like the rest of the html, and there is an attribute you can set in the array you pass to comment_form(); that allows me to change the html of the button?

    Pllleeaaasseeee? Pretty please? Please? It’d make me really really really happy.

Viewing 5 replies - 1 through 5 (of 5 total)

  • This means it gets the wrong styles.

    Uh? I can understand your frustration over the enforced <p></p> tags but I cannot understand why you think that this would impact the styling of the submit button.

    Thread Starter SamuelTurner

    (@samuelturner)

    Because <p> tags get a margin on the bottom, and I want a different margin on the bottom of the button. It can be bodged very easily, but it means adding extra CSS to fix (what I think) is a bug. I’ve done it for now but issues like this need raising, otherwise they go un-noticed.

    Because <p> tags get a margin on the bottom

    So change that via your CSS.

    It can be bodged very easily, but it means adding extra CSS to fix (what I think) is a bug.

    It’s not a bodge. This is exactly what CSS is meant to be used for. As to whether paragraph tags around the submit button can be classed as a bug is, I think, open to opinion. But I do agree that it would be nice to have the option to change this markup via the comment_form() arguments & fields.

    Thread Starter SamuelTurner

    (@samuelturner)

    I have done for now, but it’s not ideal.

    It is a bodge, it’s removing the intended styling from a paragraph so it can contain something other than text? The standard paragraph in my eyes is a block of text with a gap after it, not a button.

    it’s removing the intended styling from a paragraph so it can contain something other than text?

    Then I’m afraid we’ll have to agree to disagree. A default paragraph tag is no different to a div tag in that it can inherit the default browser style, any default CSS set up on the p element or it can be custom styled according to it’s placement within other page elements – such as .commentform'. There is absolutely nothing in the W3C specs (HTML or CSS)that mandates only text within paragraph tags.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Comments Form Submit Button HTML – Change Request’ is closed to new replies.