Comments display as one big paragraph::WHY?

OK here is the feedback –

Towards the bottom of esv.php, on line 614, in the function esv_display(), there is a line that says “echo $content;”.

That should be “return $content;” instead.

This fixed the formatting but disabled the java popup with the scripture.

If i do this

\add_filter(‘comment_text’, ‘esv_display’, 20);
to this:
add_filter(‘comment_text’, ‘esv_display’, 40);\

and leave the original echo $content; all is well.

Thanks for the help!

carl: No, it’s not my plugin. I just downloaded it and skimmed the code.

And ideally, you should do both the 20->40 change and the echo->return change. By using an echo there instead of a return, it unintentionally disables all filters that occur after it in the filter chain. The 20->40 puts it after the wpautop filter in the chain, which would have horked up the formatting of the script code.

So do both changes, that’s my recommendation. You won’t notice any difference with the echo->return change if you also do the 20->40, but it will prevent possible breakage with other plugins.

Great info. I’m the ESV plugin creator and these comments will be most helpful. ?? Thanks!