Combine JavaScript Files breaks Header Image

Hey @andybritnell

It’s a known issue between SG Optimizer and Undsgn themes/plugins.

We are currently working on it, and we will try to include a fix in the upcoming version.

Meanwhile, please keep Combine JS disabled.

Regards,
Stanimir

Hi Stanimir

Ok thanks for that information – looking forward to getting a fix on it ??

Best wishes

Andy

Hey @andybritnell

We’ve fixed everything related to our plugin, and we will release a new version soon. I think that the JS combination will work for sites using Uncode themes.

But, there is one small thing that you should request from Uncode team to address:

They should change the following condition:
if ( elem !== null && typeof elem.classList !== 'undefined' )

TO:
if ( elem !== undefined && typeof elem.classList !== 'undefined' )

Because if an element doesn’t exist, it will return undefined instead of null.

Regards,
Stanimir

Hi Stanimir

My ‘helpful’ Uncode team came back with this!

Hi Andy,

You have to do yourself and ask them clear instructions where to change or hire a developer who can do this for you.
Imran | Undsgn? Support

So can you let me know where specifically I change this code and if I need to wait for the fix before changing it.

Many thanks

Andy

Hey @andybritnell

They should change the line I mentioned in my previous reply in themes/uncode/library/js/unit.js on line 565, 568, 571, 575, 579, and 583.

Hope this will help ??

Regards,
Stanimir

Hi Stanimir

OK – thanks for the info – I’ll hold back until you update the plugin and then make the change.

Many thanks

Andy

Hey @andybritnell

We’ve released a new version few seconds ago ??

Regards,
Stanimir

Ok Cool

Just updating it now.

Will let you know if it fixes thngs ??

Bets wishes

Andy

Please note that the file init.js is minified when the Uncode team release a new version and the minified copy is located in themes/uncode/library/js/min/unit.min.js

Hi Stanimir

I checked the site without updating code and it’s working without changing any code so good work from your team fixing that.

You can check it out at https://www.dennismaps.co.uk/

Full marks for problem solving and customer service.

Best wishes

Andy

Hi Stanimir

Does that mean even though it works I still need to make the code changes?

Many thanks

Andy

Hey @andybritnell,

Well, there is an error in the console, which doesn’t break the site or its functionality, but it will be nice if the Uncode team fixes their code.

I do not recommend making changes of plugins/themes because when a new version is released, everything will be removed after an update.

Regards,
Stanimir

Hi Stanimir

Agreed they really should pull there finger out a bit more! (English idiom)

I’m happy with this now as it’s significantly improved load speed.

Left you a 5* review as you’ve been so helpful.

Best wishes

Andy

Thank you for the kind words ??