Code error in Simple_Job_Board_Notifications class

  • Resolved clembibi33

    (@clembibi33)


    6 years, 7 months ago

    Hi,
    I detected an error in the Simple_Job_Board_Notifications class (includes/class-simple-job-board-notifications.php).
    In the job_notification_templates method :

    $message = self::email_start_template($notification_receiver, $post_id);
    BUT
    public static function email_start_template( $post_id, $notification_receiver ) {…}

    Both parameters are reversed ??

    And can you also propose filters on $headers[] variables in :
    – admin_notification method,
    – hr_notification method,
    – applicant_notification method
    (in Simple_Job_Board_Notifications class)

    Thanks ??

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author PressTigers

    (@presstigers)

    Hello @clembibi33,

    Thank you for writing to us.

    Please share your site URL so that we can look into your issue.

    Regards,

    Thread Starter clembibi33

    (@clembibi33)

    Hello @presstigers,

    Here it is the website : https://www.vitivista.com/jobs

    Thank you

    Plugin Author PressTigers

    (@presstigers)

    Hi @clembibi33,

    Thank you for replying.

    Currently, there are no jobs available on your site for testing.

    Please create some jobs from the backend so that we can look into your issue.

    Regards,

    Thread Starter clembibi33

    (@clembibi33)

    Hi @presstigers,

    Yes, there are no jobs yet because this part is still under development.

    In fact, I do not have any functional problems… I contacted you for two things:

    • – To report a syntax error in the php code :
      In includes/class-simple-job-board-notifications.php file > job_notification_templates method, the call of the function is :
      $message = self::email_start_template($notification_receiver, $post_id);
      while the signature of the function is :
      public static function email_start_template( $post_id, $notification_receiver ) {…}
      Then, in the next update, it would have to change to :
      $message = self::email_start_template($post_id, $notification_receiver);
    • – To see if it was possible to add filters for developers (apply_filters) in the next release :
      In includes/class-simple-job-board-notifications.php file, can you add apply_filters to $headers[] variables in admin_notification method, hr_notification method and applicant_notification method
      For instance, $headers[] = apply_filters('sjb_admin_notification_from', 'From: ' . get_bloginfo('name') . ' <' . esc_attr( $admin_email ) . '>', $admin_email);

    I hope I’m pretty clear ??

    Regards,

    Plugin Author PressTigers

    (@presstigers)

    @clembibi33,

    We apologize for the inconvenience & thank you for reporting this issue. We will make this change live in next release of SJB.

    Also, we will add filters to “from parameter” of Admin, HR & Applicant email.

    Thank you for reaching us out. Let us know if we can assist you further.

    Regards,

    • This reply was modified 6 years, 7 months ago by PressTigers.
    Thread Starter clembibi33

    (@clembibi33)

    @presstigers,

    Thank you !

    In the same way, can you also add filters to “Reply-to parameter” of Admin, HR and Applicant email ?
    For example :
    $headers[] = apply_filters('sjb_admin_applicant_notification_reply_to','Reply-To: ' . get_bloginfo('name') . '<' . $from_email . '>',$from_email);

    Thank you very much,

    Regards,

    Plugin Author PressTigers

    (@presstigers)

    Yes, we can add. Please contact us at support@presstigers.com for the updated files. Thanks!

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Code error in Simple_Job_Board_Notifications class’ is closed to new replies.