Code change request

  • I’ve written about this to Matt but haven’t heard anything back and so, I’m posting this here as well :p Basically, the problem is this. The WP code calls all hooked actions for ‘comment_post’ after it has already sent out an e-mail confirming the posting of the comment or the holding of the comment for moderation based on the internal spam checks. However, if you have a anti-spam plugin, you’ll be hooking into ‘comment_post’ in your plugin but even if your plugin holds the comment for moderation based on your logic, the cofirmation e-mail has already gone out.
    So what I suggested was that WP core code holds or approves the comment and then calls the hooked actions for ‘comment_post’ and after that check the status of the comment again and then send out the confirmation of posting or held for moderation e-mail out. BTW, the code I’m talking about is in wp-comments-post.php. What do you think?

Viewing 2 replies - 1 through 2 (of 2 total)

  • Matt gets more email in one day than most of us get in a month, so it’s not surprising that he hasn’t yet got back to you.
    Have you also put this forward on the hackers’ mailing list, along with some example code, perhaps?
    Sounds like an interesting approach to me.

    Thread Starter Fahim

    (@fahim)

    LOL. Yeah, I figured he probably does but it’s been probably a week since I e-mailed him and so I thought I’d post it here. The example code is actually in the latest release of my WPBlacklist plugin – or rather in the readme.txt file :p If somebody is interested, you can download the zip file from https://sm.farook.org/files/WPBlacklist122.zip to get at the readme. I didn’t know where else to post this since while I do development, I am not that involved in WP stuff. So didn’t even know about the hacker’s mailing list – guess I’d better go try to find it ??

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Code change request’ is closed to new replies.