code 304 return compare time not correct

  • Hello,

    The return 304 code is not correct.

    if ( $http_if_modified_since && ( strtotime( $http_if_modified_since ) <= filemtime( $path_html ) ) ) {
    header( $_SERVER[‘SERVER_PROTOCOL’] . ‘ 304 Not Modified’, true, 304 );
    exit;
    }

    In the code the result return 304 if the compare time is modified file.
    The correct way is ( strtotime( $http_if_modified_since ) >= filemtime( $path_html )

    Regards,

    Auban

Viewing 3 replies - 1 through 3 (of 3 total)

  • Hello Auban,

    thanks for reporting! We will push a fix for this.

    I see you have also tackled this in your fork. It also needs to be fixed in advanced-cache.php but merging in your changes shouldn’t be affected by this. More on this in the other thread.

    Cheers

    Hi

    Is it possible to make a new version fast, this bug is for me a show stopper at the moment. I disabled the cache for now…

    @auban: big thanks for finding it!

    Alain

    We pushed the fix already but there is no new release yet. If you remove and reinstall the plugin you will get the latest version containing the fix.
    (This is part of our normal procedure to test changes before triggering everyone to update)

    Cheers

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘code 304 return compare time not correct’ is closed to new replies.