Changed behaviour since 1.4.3. / Bug empty img for articles without images.

Hi!

In principle, it should only return true when said post is using an external featured image. However, if you upgraded from a previous version, it’s possible that, according to the register in the database, a post “has” a featured image when it doesn’t.

The following SQL sentence* should fix the issue:

DELETE FROM wp_postmeta
WHERE
  meta_key = '_thumbnail_id' AND
  meta_value < 0

Please, let me know if you’re still experiencing the issue after that.

* Before executing the query make sure to backup your database.

Thx David, this does not solve the problem. On staging server there was only 1 row affected. On Production 0.
The problem still persist as described above.

I have the same problem on https://www.nomadi.hr/friske-vijesti-o-putovanjima-s-nomadima/

<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" style="background:url('') no-repeat center center;-webkit-background-size:cover;-moz-background-size:cover;-o-background-size:cover;background-size:cover;" class=" wp-post-image nelioefi" alt="" draggable="false">

i tried to set external image manually and it works

EDIT: didn’t have older versions of the plugin just installed the latest

There is definitely something wrong. I see big empty space when viewing forums after installing Nelio External Featured Image (1.4.3, WP4.4.2). Here it is: https://rugby-forum.ru/wp3/forums/forum/test-forum/ If I deactivate Nelio External Featured Image, the empty space disappears.

Can this be fixed?

@lars,

OK, let’s try a different approach. What about this other SQL query?

SELECT * FROM wp_postmeta
WHERE meta_key = '_thumbnail_id' AND
      meta_value NOT IN (
        SELECT ID FROM wp_posts
        WHERE post_type = 'attachment'
      );

This query will look for all the posts that, apparently, have a thumbnail set, but said thumbnail isn’t an actual attachment in your database. I guess this should return multiple tuples… If it does, you can remove those (using a DELETE FROM wp_postmeta statement instead of SELECT), assuming, of course, you created a backup of your database! ??

Best,

@thermotry,

That’s weird, it looks like things are working (an external featured image tag is being properly inserted), but the actual image URL is not included. :-S

Can you please contact me via e-mail (customers at nelio software dot com)? I’d like to take a closer look to your WordPress installation, for this doesn’t make sense!

Thanks!

@valery,

I didn’t see anything wrong in your forum… is the plugin disabled? Maybe the issue is somehow related to @thermotry’s (the URL of the featured image is not included, resulting in a transparent image), and your CSS rules do not specify the maximum dimensions of a featured image. In order to sole the latter, you can try to add a CSS rule such as:

img.nelioefi {
  max-width: 320px;
  max-height: 240px;
}

and see if the “big empty space” disappears…

Best,

@david,

sorry, I removed the previous demo installation some time ago. Now I recreated it again. Here is the link for you to see how the bbPress forum looks just after activating Nelio External Featured Image plugin: https://rugby-forum.ru/wp1/forums/forum/test-forum/

The code you suggested partially solves the issue. Here is a screenshot. But there is _no_ external featured image assigned to the forum. Nelio External Featured Image plugin was just installed, no images were set. Why the plugin reserves space for non-existant image?

If you like, I can add admin account for this WP installation for you to test.

Hi Valery,

You’re absolutely right. There was a tiny bug in the plugin which added an empty featured image… I uploaded version 1.4.4 of our plugin which fixes this issue, and includes a few minor improvements.

Please upgrade and let me know if it works!

Best,

@lars and @thermotry,

Update 1.4.4 might also help you… Can you please upgrade and tell me if it fixed your issue too?

Thanks!

@david,

Thank you for an update. The version 1.4.4 partially solves the problem: there is no more wasted space on empty image: https://rugby-forum.ru/wp1/forums/forum/test-forum/. But the image size is definitely wrong, when added. Here is an example: https://rugby-forum.ru/wp1/forums/topic/test-theme/t-theme/.

Adding

img.nelioefi {
	max-width: 320px;
	max-height: 240px;
}

to Custom CSS solves the problem, but I’m sure the size should be smaller by default…

@david,

I can confirm: “Bug empty img for articles without images.” is fixed.
Also the “PHP Notice” is the server logs is gone.

Thanks a lot!

BTW: I’ve noticed that the plugin is consuming pretty much time and needs tons of function calls. Maybe there is some room for optimisations…

@lars,

I’m glad to know things are finally working! And yes, there’s room for optimization; as soon as I have some time to work on it, I’ll implement them. We’re currently working on a new, awesome plugin, which might end up subsuming NelioEFI.

@valery,

Yes, that’s a problem with external featured images; if the theme does not define a concrete size via CSS, things can look broken. The CSS rule you’re probably looking looks more like this:

img.nelioefi {
  width: 100%;
  max-height: 300px;
}

Just let me know how it works!