Change tag

  • Resolved jordanwebdev

    (@jordanwebdev)


    3 years, 8 months ago

    Achecker.ca reports the following. Please change the <i> element to <em> or <strong>. I think <span> would work as well. It’s on line 53 of modules/gmap/views/tpl/gmapDrawMap.php

    1.4 Distinguishable: Make it easier for users to see and hear content including separating foreground from background.

Success Criteria 1.4.4 Resize text (AA)

Check 117: i (italic) element used.
Repair: Replace your i elements with em or strong.
Error Line 253, Column 162:

<i class="gmpKMLLayersPreloader fa fa-spinner fa-spin" aria-hidden="true" style="display: none;"></i ...
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support Support Ole

    (@trsupsys)

    Hi, @jordanwebdev
    Thank you for contacting us regarding your question!
    Do not trust such checkers for any reason.
    This is a Font Awesome vector icon.
    Font Awesome is designed to be used with inline elements, and recommend sticking with a consistent HTML element to reference them by in your project.
    FA like the <i> tag for brevity and because most folks use for emphasized/italicized semantic text these days.

    Best wishes,
    Ole

    Thread Starter jordanwebdev

    (@jordanwebdev)

    FA also says span is more semantically correct

    We like the <i> tag for brevity and because most folks use for emphasized/italicized semantic text these days. If that’s not your cup of tea, using a <span> is more semantically correct.

    WCAG 2.0 website compliance is law in some places, so it’s not really something that’s up for interpretation.

    How about adding an option to use it, reverting to <i> by default?

    Plugin Support Support Ole

    (@trsupsys)

    This is not currently provided in the plugin.
    We are using the default variant from Font Awesome.
    This option is added to our development scope for future releases.

    Best wishes,
    Ole

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Change tag’ is closed to new replies.