Causing other blocks to not load in editor

Hey @knutsp,

Thank you for reporting this. I’m testing this as I type. Will let you know my findings soon! ??

Hey @knutsp,

I tested Otter with Block Labs and found the reason. Few points to be noted here:

1. If you disable CSS & Animation module from here, it will start working properly: https://nimb.ws/qgoSbd

2. We add a few attributes to core blocks that extend their capabilities. We use WordPress’ APIs which work just fine with all tested blocks.

3. Seems like Block Labs plugin isn’t able to handle the attributes which aren’t pre-defined and don’t accept new attributes added via Block API. In which case it’s an issue with Block Lab and they should fix it.

Let me know if you have any follow up questions. ??

Thanks, that worked! If Block Lab gets this fixed, I can turn those back on.

Glad it worked. Have a great week ahead! ??

Hi @hardeepasrani,
Thanks for looking at this, I’m Ryan from Block Lab. Hope it’s alright to carry on the discussion here.

Good point that it works well when disabling ‘Enable Custom CSS Module’ and ‘Enable Blocks Animation Module.’

It looks like this issue also appears on Core dynamic blocks that use <ServerSideRender>:

https://cldup.com/DUGKttxBYA.png

• Tag Cloud
• Archives
• Calendar
• Latest Comments

Hey @ryankienstra!

Thanks for the finding. I’ll look into it and get back to you. Seems to be an issue on our side. Regardless, you should still make your plugin not break in such instances as a lot of plugins in future will use such APIs and not all of them will have you debugging this to figure this out. ??

Seems weird that ServerSideRender component isn’t able to handle the extra props passed to it.

Will run some tests and get back to you later this week. It turns out there’s no way then we can probably create an issue on Gutenberg Github about it and see how we can improve the component itself to not render itself unusable when extra props are passed.

Thank you once again for your time. ??

For future ref, issue on Github: https://github.com/Codeinwp/otter-blocks/issues/86

Hi @hardeepasrani, thanks for looking at this and your super-fast response ??

Did some research and saw there was a block_attributes filter to solve this mess but…Gutenberg removed it before it was added to 5.0.

Opened an issue here: https://github.com/WordPress/gutenberg/issues/16850

Let’s see if they see it as a bug or provide an alternative. If not then will have to find a way to check if the block is a dynamic one or not which is not an ideal way to do. ??

@hardeepasrani @ryankienstra I saw the Github issue on Block Lab and I think I could help ??

• This reply was modified 5 years, 8 months ago by Jeffrey Carandang.
• This reply was modified 5 years, 8 months ago by Jeffrey Carandang.

Hey @phpbits,

Thank you for that. Sure, you can send a PR if you’d like to do it, but would actually like to wait and first see what is the response of Gutenberg team about this. ??

What do you think?

@hardeepasrani No worries here ?? I’ve ask @ryankienstra too if he want the fixes to be added on Block Lab. Otherwise, let’s just wait for Gutenberg. Btw, have you tried checking the issue with Gutenberg plugin installed?

Sure, there you go:

– https://github.com/Codeinwp/gutenberg-animation
– https://github.com/Codeinwp/gutenberg-css

Both plugins are maintained as separate packages. ??

@hardeepasrani No worries here ?? I’ve ask @ryankienstra too if he want the fixes to be added on Block Lab.

Hi @phpbits, could you please remind me where you asked me this? Thanks!