case-sensitive vendor name induced problems

  • Resolved dmasin

    (@dmasin)


    6 years, 5 months ago

    Hi,
    It seems to me that the plugin was messed up with introduction of case-sensitive display vendor name (wcv_get_vendor_name function).
    For example, in class-wc-account-links.php, permalink become-a-vendor is registered, but become-a-Vendor is called by defualt so with pretty permalinks the account page gives 404 error. This could be resolved by setting “vendor” instead of “Vendor” name in plugin options: not good. Vendor name in settings should be case insensitive in my opinion.
    Other problem, the name is not run through translation filter, so it is not translated. I had to crrect it by
    add_filter( ‘wcv_vendor_display_name’, ‘my_wcv_vendor_display_name’, 10, 2 );
    function my_wcv_vendor_display_name($vendor_label) {
    $vendor_label = __( $vendor_label, ‘wc-vendors’ );
    return $vendor_label;
    }
    The most significant problem for me is however that emails are not sent to vendors on order (already pointed out here in the forum by someone else). I do not know whether this is due to case-sensitive vendor name or not. Hope that this will be resolved soon, as I have to forward admin emails to vendors manually!!!

    The page I need help with: [log in to see the link]

Viewing 2 replies - 1 through 2 (of 2 total)
  • Jamie

    (@digitalchild)

    Hello,

    Thanks for reporting your issues. The 404 is not to do with the become a vendor as the label is the only thing that is passed through the naming function. All the end points are hard coded to become-a-vendor at this point. The 404 is due to when the rewrite and end points were being loaded as they were being loaded at the wrong time. This was fixed today and will be out in the next release.

    I will also check the translation issue and have this resolved for the next update.

    Regarding the emails this is an open issue that is still being investigated. To manually fire the emails you can do this from the order edit screen.

    1. Edit the order
    2. Order actions select ‘Resend vendor new order notification’
    3. Click update

    This will manually fire the emails to the vendors without having to forward the admin emails. The email issue will be resolved in the next update.

    cheers,

    Jamie.

    Thread Starter dmasin

    (@dmasin)

    Hi Jamie,
    Thanks for checking my issues and for responding!
    Looking forward to the plug-in updates.
    Regards David

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘case-sensitive vendor name induced problems’ is closed to new replies.